UI - Implement personalization screen for quick links #19271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renames:PersonalizationShortcutsViewModelSlice to ShortcutsPersonalizationViewModelSlice
AjeshRPai
changed the title
AjeshRPai
changed the title
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19271-315661a | |
| Commit | 315661a | |
| Direct Download | wordpress-prototype-build-pr19271-315661a.apk |
* Renames: PersonalizationViewModelTest to DashboardCardPersonalizationViewModelSliceTest
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19271-315661a | |
| Commit | 315661a | |
| Direct Download | jetpack-prototype-build-pr19271-315661a.apk |
Base automatically changed from
issue/unified-dashboard-refactoring-part-2-site-header
to
UI-Modernization-Remove-tabs-and-update-quick-links-layout
September 27, 2023 12:51
* Renames:PersonalizationShortcutsViewModelSlice to ShortcutsPersonalizationViewModelSlice
* Renames: PersonalizationViewModelTest to DashboardCardPersonalizationViewModelSliceTest
…ing-implement-personalization-quick-links' into issue/unified-dashboard-refactoring-implement-personalization-quick-links
zwarm
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Nice work @AjeshRPai . I like that the "viewModelSlices" get their own data for this view. This is a great step forward, which we can eventually apply to MySIteViewModel.
| bloggingRemindersStore.updateBloggingReminders(current.copy(isPromptsCardEnabled = isEnabled)) | ||
| override fun onCleared() { | ||
| super.onCleared() | ||
| shortcutsPersonalizationViewModelSlice.onCleared() |
There was a problem hiding this comment.
❤️ Thanks for adding this. Now we can be sure that the scopes are canceled in the viewModel slices.
| blazeFeatureUtils.isSiteBlazeEligible(site) | ||
|
|
||
| fun onCleared() { | ||
| this.scope.cancel() |
| <string name="personalization_screen_footer_cards"> Cards may show different content depending on what\'s happening with your site</string> | ||
| <string name="personalization_screen_cards_tab_title">Cards</string> | ||
| <string name="personalization_screen_shortcuts_tab_title">Shortcuts</string> | ||
| <string name="personalization_screen_tab_cards_description">Add or hide Cards</string> |
There was a problem hiding this comment.
❔ Thinking out loud; could we have repurposed the original string and not done translation again, by updating all the string files. Not necessary, but just a thought.
zwarm
merged commit 70f525c
into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
zwarm
deleted the
issue/unified-dashboard-refactoring-implement-personalization-quick-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ##19270
Description
This PR implements the personalization screen for shortcuts
📷 Screenshot
To test:
Regression Notes
Potential unintended areas of impact
Nothing as this is a new screen
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
Unit tests
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: