Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Dashboard: Refactoring Part 2 - Remove Tabs from viewmodel and view #19263

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Sep 26, 2023

Part of #
#19270

This PR

  1. Removes the collapsing tool bar dynamic height logic
  2. Removes the tracking with tab source logic from MySiteViewModel
  3. Removes the quick start tab step from QuickStartRepository
  4. Removes: the redundant MySiteMenuFragment and MySiteMenuActivity

To test:

Site header and cards are shown as expected

  1. Login to JP app with an account having sites
  2. Verify that the site header and all cards are shown
  3. Click on More in Quick links, verify that the menu items are shown as expected

No sites empty view is shown

  1. Login to JP app with an account having no sites
  2. Verify that the empty sites view is shown

WP app dashboard is as expected

  1. Login to WP with an account having sites
  2. Verify that the site header is shown
  3. Verify the items shown on dashboard is as expecte

Regression Notes

  1. Potential unintended areas of impact
    Dashboard in WP/JP app is not shown correct

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual tests and Unit tests

  3. What automated tests I added (or what prevented me from doing so)
    Unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AjeshRPai AjeshRPai self-assigned this Sep 26, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 26, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19263-6e735be
Commit6e735be
Direct Downloadjetpack-prototype-build-pr19263-6e735be.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 26, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19263-6e735be
Commit6e735be
Direct Downloadwordpress-prototype-build-pr19263-6e735be.apk
Note: Google Login is not supported on these builds.

@AjeshRPai AjeshRPai requested a review from zwarm September 27, 2023 07:32
@AjeshRPai AjeshRPai added this to the 23.4 milestone Sep 27, 2023
@AjeshRPai AjeshRPai marked this pull request as ready for review September 27, 2023 10:38
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @AjeshRPai - This one is looking good and works as expected. Nice refactoring.

@zwarm zwarm merged commit 73568f8 into UI-Modernization-Remove-tabs-and-update-quick-links-layout Sep 27, 2023
@zwarm zwarm deleted the issue/unified-dashboard-refactoring-part-2-site-header branch September 27, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants