Unified Dashboard: Refactoring Part 1

[zwarm]

Part of #19270

This PR starts refactoring for unified dashboard

• Removes the initial screen from the app setting view (does not remove getting/setting helper methods from AppPrefsWrapper or AppPrefs - this will be done separately)
• Renames MySiteTabFragment to MySiteMenuFragment
• Renames my_site_tab_fragment to my_site_menu_fragment
• Removes onCreateSiteResult

The Menu logic was extracted out into standalone classes with no reliance on source manager or mysiteviewmodel. The more tap will launch the new set of activities. The old classes were not removed and can be launched by removing the comment in MySiteFragment line 649.

• Adds MenuActivity and MenuViewModel into the menu package under MySite
• Enabled More tab to launch the MenuActivity instead of the MySiteMenuFragment

Notes

• The compose pieces need some tidying up/styling.
• Quick start does not function the new MenuActivity. Focus points will work, but unless the activeTask is known, the builder won't set the focus point.
• Unit tests will come after if it is decided that we will continue with this approach

To test:

• Install the app and login
• Choose a site
• Navigate to My Site > More
• ✅ Verify the Menu view is displayed
• ✅ Verify all navigation actions work as normal

Regression Notes

1. Potential unintended areas of impact
   The more menu is not shown or working properly

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19244-22d70df
	Commit	22d70df
	Direct Download	jetpack-prototype-build-pr19244-22d70df.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19244-22d70df
	Commit	22d70df
	Direct Download	wordpress-prototype-build-pr19244-22d70df.apk

Note: Google Login is not supported on these builds.

[AjeshRPai]

Hey @zwarm
Way to go. This is a great start. I think we can build on the changes in this PR

The UI looks good to me overall. I did a smoke test of the app

• Accessed all the menu items 🟢
• Shortcuts of the of the app - Stats especially 🟢

I have ignored the issues with quick start in this PR as we can take up those in a seperate PR

[AjeshRPai]

Hey @zwarm
💡 AFAIK only plan item is using UiStringText and @ravishanker confirmed that we can safely remove plans feature from the app since they are planning a revamp for plans in site creation.
We can take up this change in a seperate PR but just letting you know.

[AjeshRPai]

Hey @zwarm
I think you missed removing the Unified keyword from the compose views, so I did it through the commit 22d70df. Hope thats ok