Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JP Social] Create improvements feature config and enable it by default #18897

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

thomashorta
Copy link
Contributor

Should be merged only after #18895

Sets the remote field jetpack_social_improvements_v1 to the JetpackSocialFeatureConfig and enables it by default.

To test:

  1. Open the app
  2. Go to Debug Settings
  3. Verify the jetpack_social_improvements_v1 FeatureConfig is enabled by default
  4. Go to Posts
  5. Open a Draft post / create a new post
  6. Open the Post Settings
  7. Verify the JP Social section is available
  8. Hit Publish
  9. Verify the JP Social item is available in the pre-publish sheet

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A, just feature flag work.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2023

Fails
🚫 This PR is tagged with 'Do Not Merge' label.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18897-b8decc6
Commitb8decc6
Direct Downloadwordpress-prototype-build-pr18897-b8decc6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18897-b8decc6
Commitb8decc6
Direct Downloadjetpack-prototype-build-pr18897-b8decc6.apk
Note: Google Login is not supported on these builds.

Base automatically changed from issue/jp-social-prepublish-on-posts-list-drafts to trunk August 5, 2023 00:30
@thomashorta thomashorta added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Aug 5, 2023
@RenanLukas RenanLukas added [Type] Task Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Jetpack Social and removed [Type] Task Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Jetpack Social labels Aug 5, 2023
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @thomashorta. It's working as expected.

LGTM :shipit:

@RenanLukas RenanLukas added [Type] Task Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Jetpack Social and removed [Type] Task Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Jetpack Social labels Aug 5, 2023
@RenanLukas RenanLukas merged commit 1494dbd into trunk Aug 5, 2023
@RenanLukas RenanLukas deleted the issue/jp-social-improvements-feature-config branch August 5, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants