Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg - Hide undo/redo buttons in HTML Mode #18889

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Aug 4, 2023

This PR fixes an issue where the undo/redo buttons in the editor are visible when toggling to HTML mode.

These buttons don't have any functionality while editing in HTML so we should hide them and show them back if the user toggles back to the Visual mode.

To test:

  • Open the app
  • Open the editor
  • Toggle to HTML mode by tapping on the more options (...) three dots in the right area of the navigation bar
  • Expect to see the HTML editor and the undo/redo buttons to be hidden
  • Toggle back to the Visual mode by tapping on the more options (...) three dots in the right area of the navigation bar
  • Expect to see the undo/redo buttons in the navigation bar
Functionality
UndoRedoHTMLEditorAndroid.mov

Regression Notes

  1. Potential unintended areas of impact
    It affects only the block editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and added UI tests

  3. What automated tests I added (or what prevented me from doing so)
    I added extra steps to testUndoRedo for the EditorGutenbergTests, which includes adding a new HTMLEditorScreen.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@geriux geriux added Testing Gutenberg Editing and display of Gutenberg blocks. labels Aug 4, 2023
@geriux geriux added this to the 23.1 milestone Aug 4, 2023
@geriux geriux marked this pull request as ready for review August 4, 2023 14:22
@geriux geriux requested a review from a team as a code owner August 4, 2023 14:22
@geriux geriux self-assigned this Aug 4, 2023
@geriux geriux requested a review from thomashorta August 4, 2023 14:29
@geriux
Copy link
Contributor Author

geriux commented Aug 4, 2023

Hey @thomashorta 👋 I've assigned you as a reviewer for this PR, I was wondering if you could please check it out? Since you are familiar with this feature 😃 Let me know if you can review it, thank you!

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18889-976a0ca
Commit976a0ca
Direct Downloadwordpress-prototype-build-pr18889-976a0ca.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18889-976a0ca
Commit976a0ca
Direct Downloadjetpack-prototype-build-pr18889-976a0ca.apk
Note: Google Login is not supported on these builds.

@irfano irfano self-requested a review August 17, 2023 07:15
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature and tests work as explained. LGTM! 👍🏻

@irfano irfano merged commit 0dbaaee into trunk Aug 17, 2023
@irfano irfano deleted the gutenberg/hide-undo-redo-html-mode branch August 17, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants