Domain transfer dashboard card #18852

ravishanker · 2023-07-28T07:56:23Z

Adds dashboard card for domain transfer

Fixes: See

Domain Transfer Card	Domain Transfer Intro

To test:

Launch Jetpack app
Verify domains transfer card appears as shown above on dashboard
Tap on the Learn more or anywhere on the card
Verify it launches domain transfer page
Tap on overflow (three dots) menu on the card
Verify it pops up menu with Hide this option
Tap on Hide this
Verify, the card gets hidden

Check for the following tracks in AS
🔵 Tracked: dashboard_card_domain_transfer_shown
🔵 Tracked: dashboard_card_domain_transfer_more_menu_tapped
🔵 Tracked: dashboard_card_domain_transfer_hidden

Note
Copy on the card could change later

Regression Notes

Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Unit tests and manual tests
What automated tests I added (or what prevented me from doing so)
Updated and added unit tests

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Create card layout Create ViewHolder Create and update card builder Add preferences for hiding card Add tracks Add navigation to launch transfer page Update MySiteViewModel.kt Update MySiteTabFragment.kt

wpmobilebot · 2023-07-28T08:14:46Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18852-d18fb69
	Commit	`d18fb69`
	Direct Download	`wordpress-prototype-build-pr18852-d18fb69.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-07-28T08:17:28Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18852-d18fb69
	Commit	`d18fb69`
	Direct Download	`jetpack-prototype-build-pr18852-d18fb69.apk`

Note: Google Login is not supported on these builds.

Use ActivityNavigator in lieu of Activity Launcher

Updated content to latest copy

AjeshRPai

Hey @ravishanker

I have tested this PR according to the instructions in the PR description. Everything looks good to me. I have left a ❓ Question, 💡 Suggestion. They are not blocking, so approving but not merging so that you can address them in this PR if necessary. If you think, there is no changes necessary/can be taken up in another PR, feel free to merge 👍🏼

AjeshRPai · 2023-08-02T06:31:50Z

WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt

+        context: Context,
+        url: String
+    ) {
+        WPWebViewActivity.openUrlByUsingGlobalWPCOMCredentials(context, url)


👏🏼 [praise] : Thanks for using this class

WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt

...rdpress/android/ui/mysite/cards/dashboard/domaintransfer/DashboardCardDomainTransferUtils.kt

AjeshRPai · 2023-08-02T07:25:43Z

Hey @ravishanker

I was getting some build errors, mostly due to the migration to the latest AGP. Hence I updated this branch with trunk. I was able to build and test it after that.

peril-wordpress-mobile · 2023-08-03T06:36:59Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

AjeshRPai

Hey @ravishanker

Reviewed it again, everything looks good to me 👍🏼 . Approved, enabling automerge

ravishanker added 10 commits July 28, 2023 17:00

Create card layout

00134d6

Create ViewHolder

37d47f2

Create and update card builder

10e72fb

Add preferences for hiding card

c8d3fa7

Add tracks

8f47a18

Add navigation to launch transfer page

49cf09b

Update MySiteViewModel.kt

58a0c14

Update MySiteTabFragment.kt

00c614b

Update tests

240cdac

fix redundant commits

9daab41

Create card layout Create ViewHolder Create and update card builder Add preferences for hiding card Add tracks Add navigation to launch transfer page Update MySiteViewModel.kt Update MySiteTabFragment.kt

ravishanker added [Type] Task Domains labels Jul 28, 2023

ravishanker added this to the 23.0 milestone Jul 28, 2023

ravishanker self-assigned this Jul 28, 2023

ravishanker added 4 commits July 29, 2023 10:55

update icon

a244e58

Use Compose for card view

db52813

Refactor for Compose card

305f47e

Delete unused after updating to Compose

b9c4932

ravishanker requested a review from AjeshRPai July 29, 2023 04:59

ravishanker marked this pull request as ready for review July 29, 2023 05:00

ravishanker added 2 commits July 29, 2023 15:30

Update RELEASE-NOTES.txt

869f5af

Use ActivityNavigator

3ec4350

Use ActivityNavigator in lieu of Activity Launcher

ravishanker added the Domains Dashboard Card label Jul 31, 2023

ravishanker and others added 3 commits August 2, 2023 13:29

Update copy

f142615

Updated content to latest copy

Update url

a9e5cdf

Merge branch 'trunk' into Domain-Transfer-Dashboard-card

58ec23e

AjeshRPai approved these changes Aug 2, 2023

View reviewed changes

ravishanker added 10 commits August 3, 2023 11:24

Create DomainTransferCardViewModel.kt

184990a

Rename Card builder

3910935

Delete DashboardCardDomainTransferUtils.kt

fe1e517

Update MySiteViewModel.kt

99fc923

Update MySiteFragment.kt

dfdf611

Update copy

ed213a9

Update CardsBuilderTest.kt

b6c6235

Update CardsBuilderTest.kt

0d2acdc

Update MySiteViewModelTest.kt

ca659d7

Fix MySiteViewModelTest

8a44d32

AjeshRPai approved these changes Aug 3, 2023

View reviewed changes

AjeshRPai enabled auto-merge August 3, 2023 10:03

ravishanker added 2 commits August 4, 2023 08:34

Merge branch 'trunk' into Domain-Transfer-Dashboard-card

4ee58d7

Update ContacUsTest to run only for JP

3faa7f9

ravishanker requested a review from a team as a code owner August 4, 2023 02:18

ravishanker and others added 3 commits August 4, 2023 20:19

Update ContactUsTests.kt

39bdb06

Unregister Compose-Espresso link at some parts of UI Tests.

266ec9a

Merge branch 'trunk' into Domain-Transfer-Dashboard-card

d18fb69

AjeshRPai merged commit 280dfa7 into trunk Aug 6, 2023

AjeshRPai deleted the Domain-Transfer-Dashboard-card branch August 6, 2023 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Domain transfer dashboard card #18852

Domain transfer dashboard card #18852

ravishanker commented Jul 28, 2023 •

edited

Loading

wpmobilebot commented Jul 28, 2023 •

edited

Loading

wpmobilebot commented Jul 28, 2023 •

edited

Loading

AjeshRPai left a comment

AjeshRPai Aug 2, 2023

AjeshRPai commented Aug 2, 2023

peril-wordpress-mobile bot commented Aug 3, 2023 •

edited

Loading

AjeshRPai left a comment

Domain transfer dashboard card #18852

Domain transfer dashboard card #18852

Conversation

ravishanker commented Jul 28, 2023 • edited Loading

Regression Notes

wpmobilebot commented Jul 28, 2023 • edited Loading

wpmobilebot commented Jul 28, 2023 • edited Loading

AjeshRPai left a comment

Choose a reason for hiding this comment

AjeshRPai Aug 2, 2023

Choose a reason for hiding this comment

AjeshRPai commented Aug 2, 2023

peril-wordpress-mobile bot commented Aug 3, 2023 • edited Loading

AjeshRPai left a comment

Choose a reason for hiding this comment

ravishanker commented Jul 28, 2023 •

edited

Loading

wpmobilebot commented Jul 28, 2023 •

edited

Loading

wpmobilebot commented Jul 28, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Aug 3, 2023 •

edited

Loading