-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement navigation and tracking for Campaigns dashboard card #18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Adds: a class for handling the logic related to Blaze events to seperate it from MySiteViewModel + Adds: the logic to handle the click and track the events on clicking at the promo card
* Updates: the logic in MySiteViewModel to use BlazeViewModelSlice
AjeshRPai
changed the base branch from
trunk
to
issue/styling-of-the-dashboard-card
July 17, 2023 14:36
…8525_implement_click_and_tracking
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
+ Adds: Parent activity for showing campaigns and campaign detail
+ Adds: CampaignListingFragment and CampaignListingViewModel for listing the campaigns
Updates: the logic to remove the redundant logic and this will be added in a seperate PR
+ Adds: Blaze Campaign page + Adds: Blaze Campaign Parent Viewmodel + Adds: Blaze Campaign UI state for navigating to list/detail page
…8525_implement_click_and_tracking # Conflicts: # WordPress/src/main/res/values/strings.xml
+ Adds: the logic to navigate to campaign listing page when campaigns feature is enabled otherwise navigate to blaze flow
AjeshRPai
changed the title
Implement click and tracking campaigns
Implement navigation and tracking for Campaigns dashboard card
Jul 19, 2023
Updates: MySiteViewModelTest to remove the blaze dependancies as those will be tested in a seperate class targeting BlazeCardViewModelSlice
* Changes the order as in the usage
zwarm
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - things are looking good. A few small refactor areas. My compose knowledge is very low, so it's hard for me to say the code is efficient, but it works. :)
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/BlazeCardViewModelSlice.kt
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
#18521
#18525
Description
This PR implements the tracking and click logic in the Campaigns Card
This PR implements the following click events and the tracking associated with it in Campaigns card
Also Implements the Site Menu Navigation
blaze_campaigns
is enabledblaze_campaigns
is disabledAlso note that I have added the Skeleton classes for Campaign listing page and Detail page in this PR. There is no need to test these classes as of now since the logic will change in these classes
To test
Hide is working as expected, and my site refresh indicator is shown
Tracking is working as expected when the promo card shown
Tracking is working as expected when the campaigns card shown
Click on the Menu item - Blaze campaign enabled
Click on the Menu item - Blaze campaign disabled
Click on the Dashboard Card - Blaze Campaign
Ripple effect and Padding, Verify that the BlazeCampaignCard UI is as expected - compare it with the PR or Figma design
I had to re-arrange and add some columns in
BlazeCampaignCard
.This is due to the fact that the click ripple of the view doesn’t fill the padding of the view in which click behavior is added. So adding padding to the column and setting it clickable makes the ripple to only fill the content. In order to fix that, I moved the padding from the parent column to the child view and set the parent clickable which makes the entire content to have the ripple effect.
Merge Instructions
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: