Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Editor] Add remote FF to SiteEditorMVP and default to on #18454

Merged
merged 4 commits into from
May 19, 2023

Conversation

thomashorta
Copy link
Contributor

Fixes #18441

Add remote field to Site Editor MVP FF (site_editor_mvp) and default it to ON.

Not ready for merge: we probably need to add something to the release notes.

To test:
Verify that on a clean install, the Site Editor MVP feature (virtual homepage item for block-based sites in the Pages List) is on by default. Also, check that the site_editor_mvp is available in the Debug Settings.

Instructions to test the feature itself can be found here: #18436

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • N/A UI Changes testing checklist

@thomashorta thomashorta added this to the 22.5 milestone May 17, 2023
@thomashorta thomashorta requested a review from RenanLukas May 17, 2023 22:51
@thomashorta thomashorta self-assigned this May 17, 2023
@thomashorta thomashorta changed the base branch from trunk to issue/18371-virtual-homepage-track May 17, 2023 22:51
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 17, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18454-55d5762
Commit55d5762
Direct Downloadwordpress-prototype-build-pr18454-55d5762.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 17, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18454-55d5762
Commit55d5762
Direct Downloadjetpack-prototype-build-pr18454-55d5762.apk
Note: Google Login is not supported on these builds.

Base automatically changed from issue/18371-virtual-homepage-track to trunk May 18, 2023 19:41
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thomashorta thomashorta merged commit bb5ac78 into trunk May 19, 2023
@thomashorta thomashorta deleted the issue/18441-site-editor-remote-ff branch May 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Site Editor] Add remote field to SiteEditorMVPFeatureConfig
3 participants