[Sharing] Fix Tumblr form being pushed down #18289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NestedScrollView behavior paired with the WebView was causing the webview height to increase indefinitely while the tumblr login was trying to center its content vertically, causing the login form to be pushed down. This likely didn't happen with other services because they do not center their content vertically or at least don't do it the same way tumblr was doing. The correct solution though was to use the NestedWebView, which was created to avoid these kind of scroll issues that can affect WebViews inside scrolling layouts.
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18289-1dd9d6c | |
| Commit | 1dd9d6c | |
| Direct Download | jetpack-prototype-build-pr18289-1dd9d6c.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18289-1dd9d6c | |
| Commit | 1dd9d6c | |
| Direct Download | wordpress-prototype-build-pr18289-1dd9d6c.apk |
RenanLukas
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Thanks for fixing it, @thomashorta. It's working as expected.
LGTM 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17401
This fixes the bug reported in this comment in the original issue.
The NestedScrollView behavior paired with the WebView was causing the
WebViewheight to increase indefinitely while the Tumblr login was trying to center its content vertically, causing the login form to be pushed down.This likely didn't happen with other services because they do not center their content vertically or at least don't do it the same way Tumblr was doing.
The correct solution though was to use the
NestedWebView, which was created to avoid this kind of scroll issue that can affect WebViews inside scrolling layouts.fix_runaway_tumblr_login.mp4
To test:
TumblrConnectExtra verification: check that the login page for the other services works as expected as well.
Regression Notes
Potential unintended areas of impact
Connection pages for other services are affected.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/A, UI only fix.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist:
Note: tested with RTL and Talkback, but since this issue refers to a WebView, I am not assessing the content behavior for this.