Runtime notifications permission #18239

irfano · 2023-04-06T04:14:01Z

Fixes #17714
This PR adds runtime notifications permission support.

Notifications screen
This adds a yellow warning box to the notifications screen. It's visible when the notification permission is not allowed.

If you tap the "x" button, it's dismissed, and you can't see it unless you allow the permission and disable it again.
FIX button opens the system's permission dialog. If you deny the permission several times, the FIX button opens the permission bottom sheet that navigates you to the device settings.

Blogging reminders
This adds a notification permission step to the blogging reminders flow. If the permission is denied and the app can't show the system's native permission dialog, the "Go to Settings → Notifications → App Settings, and turn WordPress on to be notified immediately." message will be displayed. Otherwise, it will be invisible.

Design: YSbDG4YKoDDkjEZSfBrIlN-fi-1300_13590

To test:
Test both on the API 33 device and a lower version device. The behavior shouldn't change on older devices.

Notifications screen - Allow

Launch the JP app.
Ensure you don't allow the notification permission.
Navigate to Notifications.
Notice the yellow warning box.
Tap Fix.
Ensure it opens the system's permission dialog.
Allow permission.
Ensure the warning has been lost and the permission is allowed on system settings.

Notifications screen - Deny

Launch the JP app.
Ensure you don't allow the notification permission.
Navigate to Notifications.
Notice the yellow warning box.
Tap Fix and deny the native permission dialog.
Tap Fix again.
Notice the permission bottom sheet appears.
Tap the green button. Notice it sends you to the permission settings screen.

Blogging reminders screen - Allow

Launch the JP app.
Ensure that notification permission is not allowed.
Navigate to My Site → Site Settings.
Tap Reminders.
Choose some days and tap Update.
Notice the native permission dialog.
Allow it and test the positive case.

Blogging reminders screen - Deny

Launch the JP app.
Ensure that notification permission is not allowed.
Navigate to My Site → Site Settings.
Tap Reminders.
Choose some days and tap Update.
Deny the native permission dialog.
It should open permission bottom sheet.
Tap the "Turn on notifications" button.
Ensure it navigates you to the permission settings screen.
Allow the notification permission and go back to the app.
Ensure the permission screen is passed and the next screen on the flow is opened.

Regression Notes

Potential unintended areas of impact
Setting blogging Reminders.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
Updated current tests.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

NotificationsPermissionBottomSheetFragment is a bottom sheet to navigate user to the App Settings.

wpmobilebot · 2023-04-06T04:32:29Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18239-d26cfbb
	Commit	`d26cfbb`
	Direct Download	`wordpress-prototype-build-pr18239-d26cfbb.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-04-06T04:32:33Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18239-d26cfbb
	Commit	`d26cfbb`
	Direct Download	`jetpack-prototype-build-pr18239-d26cfbb.apk`

Note: Google Login is not supported on these builds.

ravishanker · 2023-04-06T08:06:41Z

@irfano - Great work!

Notifications Screen - Allow: Suggest that entire banner is made clickable. Fix word and touch target is obscure. Not sure if it needs that x. When banner is dismissed it disappears, they may not know how to enable notifications just in case!
Notifications Screen - Deny: Didn't have to deny several time to see the Bottom sheet

Banner	Bottomsheet	Popup

ravishanker · 2023-04-06T08:11:21Z

WordPress/src/main/res/values/strings.xml

+    <string name="notifications_permission_dismiss_content_description">Dismiss notification permission warning.</string>
+    <string name="notifications_permission_off_desc">Push notifications are turned off.</string>
+    <string name="notifications_permission_bottom_sheet_title">Push notifications are turned off</string>
+    <string name="notifications_permission_bottom_sheet_description_1">You’ll need to open the app to see notifications.</string>


Missing escape \ character before ' in You'll. Also, same below L:4071

I've learned that ’ and ' are different. 😄 I copied strings from Figma, which uses ’, that's why the IDEA didn't show an error. But I've changed ’ to '. They both are okay but standard ' is more popular in our strings.

Done: 6ee77da

ravishanker

Finally, it's done! 🚀

irfano · 2023-04-06T09:42:18Z

Suggest that entire banner is made clickable. Fix word and touch target is obscure.

That makes sense 👍🏻 ~~I'll make the change.~~ Done: 63431aa

Not sure if it needs that x. When banner is dismissed it disappears, they may not know how to enable notifications just in case!

Some users may be aware that notifications are turned off and just want to close the banner. But as a side effect, other users who are unaware of it may tap "X" by mistake and lose the benefit of the banner.
Maybe we can remove the "X" button and hide the banner if permission is always denied. Wdyt?

wpmobilebot · 2023-04-06T21:53:40Z

Found 1 violations:

The PR caused the following dependency changes:

-\--- org.wordpress:utils:{strictly 3.5.0} -> 3.5.0
+\--- org.wordpress:utils:{strictly trunk-3c3d298621fda50b5cbf6b981b78920b80fa82b4} -> trunk-3c3d298621fda50b5cbf6b981b78920b80fa82b4

Please review and act accordingly

…13)' into issue/17714-notification-runtime-permission

irfano · 2023-04-06T22:25:05Z

Didn't have to deny several time to see the Bottom sheet

I think it changes that how many times you can deny the system's native permission dialog until we can't show it anymore. Because I can see and deny the system's native permission dialog twice after the clean install.
I've also made a change to the blogging reminders flow. af470ad See the updated description.

…13)' into issue/17714-notification-runtime-permission

peril-wordpress-mobile · 2023-04-07T11:10:37Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

irfano added 6 commits April 6, 2023 05:54

Add POST_NOTIFICATIONS to AndroidManifest

1e4f397

Add NotificationsPermissionBottomSheetFragment

3ecad02

NotificationsPermissionBottomSheetFragment is a bottom sheet to navigate user to the App Settings.

Update the version of WordPress-Utils library

c5cba1c

Add a function for showing notification settings of device

65b62a3

Add permission warning message to the notifications screen

4c21506

Add notifications permission step to blogging reminders flow

ddbac77

irfano added [Type] Task Android 13 labels Apr 6, 2023

irfano added this to the 22.2 milestone Apr 6, 2023

irfano requested a review from ravishanker April 6, 2023 04:14

ravishanker reviewed Apr 6, 2023

View reviewed changes

ravishanker approved these changes Apr 6, 2023

View reviewed changes

irfano added 7 commits April 6, 2023 13:08

Make the whole notifications permission banner clickable

63431aa

Prevent updating reminders in no permission case

fb0ece3

Improve notifications permission flow on blogging reminders

af470ad

Use standard ' for blogging reminders strings

6ee77da

Update RELEASE-NOTES

2c83434

Update WordPress-Utils version to trunk

9f870dd

Resolve "translatable="false" warnings on strings

3545e9c

Merge branch 'Parent-PR-for-updating-targetSdkVersion-to-33-(Android-…

6cf91df

…13)' into issue/17714-notification-runtime-permission

Merge branch 'Parent-PR-for-updating-targetSdkVersion-to-33-(Android-…

32e2a4e

…13)' into issue/17714-notification-runtime-permission

Remove duplicated item in RELEASE-NOTES

d26cfbb

irfano merged commit e1ff390 into Parent-PR-for-updating-targetSdkVersion-to-33-(Android-13) Apr 8, 2023

irfano deleted the issue/17714-notification-runtime-permission branch April 8, 2023 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtime notifications permission #18239

Runtime notifications permission #18239

irfano commented Apr 6, 2023 •

edited

Loading

wpmobilebot commented Apr 6, 2023 •

edited

Loading

wpmobilebot commented Apr 6, 2023 •

edited

Loading

ravishanker commented Apr 6, 2023 •

edited by irfano

Loading

ravishanker Apr 6, 2023 •

edited

Loading

irfano Apr 6, 2023

ravishanker left a comment

irfano commented Apr 6, 2023 •

edited

Loading

wpmobilebot commented Apr 6, 2023

irfano commented Apr 6, 2023

peril-wordpress-mobile bot commented Apr 7, 2023

Runtime notifications permission #18239

Runtime notifications permission #18239

Conversation

irfano commented Apr 6, 2023 • edited Loading

Regression Notes

wpmobilebot commented Apr 6, 2023 • edited Loading

wpmobilebot commented Apr 6, 2023 • edited Loading

ravishanker commented Apr 6, 2023 • edited by irfano Loading

ravishanker Apr 6, 2023 • edited Loading

Choose a reason for hiding this comment

irfano Apr 6, 2023

Choose a reason for hiding this comment

ravishanker left a comment

Choose a reason for hiding this comment

irfano commented Apr 6, 2023 • edited Loading

wpmobilebot commented Apr 6, 2023

The PR caused the following dependency changes:

irfano commented Apr 6, 2023

peril-wordpress-mobile bot commented Apr 7, 2023

irfano commented Apr 6, 2023 •

edited

Loading

wpmobilebot commented Apr 6, 2023 •

edited

Loading

wpmobilebot commented Apr 6, 2023 •

edited

Loading

ravishanker commented Apr 6, 2023 •

edited by irfano

Loading

ravishanker Apr 6, 2023 •

edited

Loading

irfano commented Apr 6, 2023 •

edited

Loading