-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WP Individual JP Plugin] Show dialog with overlay #18169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18169-c84ebfc | |
Commit | c84ebfc | |
Direct Download | jetpack-prototype-build-pr18169-c84ebfc.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18169-c84ebfc | |
Commit | c84ebfc | |
Direct Download | wordpress-prototype-build-pr18169-c84ebfc.apk |
ff72fa8
to
09557b4
Compare
90da5c5
to
3d07665
Compare
d9e4ef7
to
cd0a6bd
Compare
Generated by 🚫 dangerJS |
4 tasks
3 tasks
RenanLukas
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @thomashorta . All the scenarios are working as expected 🎉
I've only left a few questions.
WordPress/src/main/java/org/wordpress/android/ui/accounts/LoginEpilogueViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/util/extensions/DialogExtensions.kt
Show resolved
Hide resolved
...ss/src/main/java/org/wordpress/android/viewmodel/accounts/PostSignupInterstitialViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/viewmodel/main/SitePickerViewModel.kt
Show resolved
Hide resolved
RenanLukas
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18114
Create a dialog for showing the Overlay screen. (only in the WordPress app)
The dialog is shown on top of the following screens:
When the WP.com account has at least 1 "problem site", which fits the following conditions:
To test:
Here are some of the test scenarios (WordPress app only).
Login - At least 1 WP.com site + at least 1 "problem site"
Site Picker - At least 1 WP.com site + at least 1 "problem site"
Login - NO WP.com sites + at least 1 "problem site"
Important: this scenario only happens once, so to see it the app should be in a clear state by clearing the app data in the device settings.
My Site - NO WP.com sites + at least 1 "problem site"
Notes
There are different overlay contents for each situation below. It would be good to test all combinations, but it can be complicated getting accounts in those specific situations:
Currently there is no logic to avoid showing the overlay repeatedly, which will be added in #18175.
Regression Notes
Potential unintended areas of impact
Full-screen bottoms sheets behavior (ex: theme preview, blocs preview, jetpack feature overlay).
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
Added tests to all viewmodels showing the new overlay.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.