Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP Individual JP Plugin] Show dialog with overlay #18169

Merged
merged 20 commits into from
Mar 28, 2023

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented Mar 23, 2023

Part of #18114

Create a dialog for showing the Overlay screen. (only in the WordPress app)

The dialog is shown on top of the following screens:

  • Site Picker
  • Login Epilogue (site picker after login)
  • Post Signup Interstitial (shown after first login ever - clear data - with no WP.com sites in the account)
  • My site screen with empty state (after login with no WP.com sites in the account)

When the WP.com account has at least 1 "problem site", which fits the following conditions:

  • self-hosted site
  • has at least 1 Individual Jetpack plugin active and connected to the WP.com account
  • does NOT have the full Jetpack plugin installed

To test:

Here are some of the test scenarios (WordPress app only).

Login - At least 1 WP.com site + at least 1 "problem site"

  1. Log in to WordPress
  2. verify the Login Epilogue (site picker) shows only WP.com sites
  3. verify the overlay saying there are other sites with individual JP plugins is shown

Site Picker - At least 1 WP.com site + at least 1 "problem site"

  1. After selecting one WP.com site
  2. tap the Site selection arrow to open site picker
  3. verify the site picker shows only WP.com sites
  4. verify the overlay saying there are other sites with individual JP plugins is shown

Login - NO WP.com sites + at least 1 "problem site"

Important: this scenario only happens once, so to see it the app should be in a clear state by clearing the app data in the device settings.

  1. Log in to WordPress
  2. verify the Post Signup Interstitial is shown saying you have NO sites
  3. verify the overlay saying there are sites with individual JP plugins is shown

My Site - NO WP.com sites + at least 1 "problem site"

  1. After login, skip the Post Signup Interstitial
  2. select the My Site tab (bottom navigation bar)
  3. verify the overlay saying there are sites with individual JP plugins is shown

Notes

There are different overlay contents for each situation below. It would be good to test all combinations, but it can be complicated getting accounts in those specific situations:

  1. Single "problem site" with a single JP Individual plugin
  2. Single "problem site" with multiple JP individual plugins
  3. Multiple "problem sites" some with single JP individual plugins and some with multiple plugins

Currently there is no logic to avoid showing the overlay repeatedly, which will be added in #18175.

Regression Notes

  1. Potential unintended areas of impact
    Full-screen bottoms sheets behavior (ex: theme preview, blocs preview, jetpack feature overlay).

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    Added tests to all viewmodels showing the new overlay.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 23, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18169-c84ebfc
Commitc84ebfc
Direct Downloadjetpack-prototype-build-pr18169-c84ebfc.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 23, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18169-c84ebfc
Commitc84ebfc
Direct Downloadwordpress-prototype-build-pr18169-c84ebfc.apk
Note: Google Login is not supported on these builds.

@thomashorta thomashorta force-pushed the issue/18114-wp-jp-plugin-overlay-ui branch from ff72fa8 to 09557b4 Compare March 24, 2023 18:33
@thomashorta thomashorta force-pushed the issue/18114-wp-jp-plugin-overlay-dialog branch from 90da5c5 to 3d07665 Compare March 24, 2023 19:45
Base automatically changed from issue/18114-wp-jp-plugin-overlay-ui to trunk March 24, 2023 21:27
@thomashorta thomashorta force-pushed the issue/18114-wp-jp-plugin-overlay-dialog branch from d9e4ef7 to cd0a6bd Compare March 24, 2023 22:18
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 24, 2023

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@thomashorta thomashorta requested a review from RenanLukas March 24, 2023 22:49
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @thomashorta . All the scenarios are working as expected 🎉

I've only left a few questions.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants