Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JP Install Full Plugin] Enable feature flag and update release notes #17983

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

RenanLukas
Copy link
Contributor

Fixes #17837

To test:

  • Install app and select site with only individual plugins;
  • Open home screen: the JP full plugin install card should be shown.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    Feature config files are currently not testable.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2023

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17983-cc0dcd7.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitcc0dcd7
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17983-cc0dcd7.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitcc0dcd7
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@develric develric self-requested a review February 19, 2023 03:50
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @RenanLukas , built the JP vanilla debug and checked for the feature to be active. Also did some smoke testing of the feature and looks good 👍 ! :shipit:

@RenanLukas RenanLukas merged commit 04b6c9e into trunk Feb 19, 2023
@RenanLukas RenanLukas deleted the issue/17837-enable-jetpack-install-full-plugin-ff branch February 19, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the feature flag and update release notes
3 participants