-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JP Install Full Plugin] Enable feature flag and update release notes #17983
Merged
RenanLukas
merged 3 commits into
trunk
from
issue/17837-enable-jetpack-install-full-plugin-ff
Feb 19, 2023
Merged
[JP Install Full Plugin] Enable feature flag and update release notes #17983
RenanLukas
merged 3 commits into
trunk
from
issue/17837-enable-jetpack-install-full-plugin-ff
Feb 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17983-cc0dcd7.apk
|
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17983-cc0dcd7.apk
|
Generated by 🚫 dangerJS |
develric
approved these changes
Feb 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @RenanLukas , built the JP vanilla debug and checked for the feature to be active. Also did some smoke testing of the feature and looks good 👍 !
RenanLukas
deleted the
issue/17837-enable-jetpack-install-full-plugin-ff
branch
February 19, 2023 04:13
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17837
To test:
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
Feature config files are currently not testable.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.