Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the new landing screen in WordPress app #17871

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Feb 2, 2023

Closes #17870

This PR enables the new landing screen in the WordPress app. Testing was already done as part of the project implementation.

To be merged only after the release/21.7 branch is cut.

To test:

  1. Verify CI checks pass.
  2. Open WP and JP app
  3. Verify The new landing screen is displayed when logged out

Regression Notes

  1. Potential unintended areas of impact
    N/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/a

  3. What automated tests I added (or what prevented me from doing so)
    N/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ovitrif ovitrif added this to the 21.8 milestone Feb 2, 2023
@ovitrif ovitrif self-assigned this Feb 2, 2023
@ovitrif ovitrif changed the base branch from trunk to feature/add-compose-ui-testing-support February 2, 2023 18:14
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 2, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17871-3904eeb.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit3904eeb
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17871-a4a0968.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commita4a0968
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Base automatically changed from feature/add-compose-ui-testing-support to trunk February 3, 2023 16:12
@ovitrif ovitrif force-pushed the feature/enable-new-wp-landing-screen branch from a4a0968 to 3904eeb Compare February 7, 2023 09:58
@ovitrif ovitrif requested review from antonis and mkevins February 7, 2023 09:58
@ovitrif ovitrif marked this pull request as ready for review February 7, 2023 09:59
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this @ovitrif 🙇
The code changes look good and the CI build I've tested on my Pixel 5/Android 13 showed the new landing screen as expected 🎉

@antonis antonis enabled auto-merge February 7, 2023 10:13
@antonis antonis merged commit 310f922 into trunk Feb 7, 2023
@antonis antonis deleted the feature/enable-new-wp-landing-screen branch February 7, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Revamp Landing Screen] Enable the new Landing Screen in the WordPress app
3 participants