Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wp support forum card on help screen #17820

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Jan 25, 2023

Adds Forum Support card on Help Screen

Fixes #17807

Before After
Screenshot_20230125_115249 Screenshot_20230125_115356

To test:

Test 1

  • Navigate to Me > Help & Support
  • Verify that screen is as shown in Before above
  • Tap on Contact Support
  • Verify that it opens the Zendesk form as before

Test 2

  • Navigate to Me > App Settings > Debug settings
  • Enable wordpress_support_forum_remote_field under Remote features and Restart the app (scroll down if required)
  • Navigate to Me > Help & Support
  • Verify that the screen is as shown in After above
  • Tap on the Community forums row
  • Verify that it opens the new Mobile Forum on Wordpress.org in the browser

Note
An entry point in Gutenberg will be handled in a separate PR

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested with WP and JP app variants

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Added new support forum row for WP
handle support forum card based on feature config
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17820-b6d7e47.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitb6d7e47
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2023

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17820-b6d7e47.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitb6d7e47
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The last item of Test 1 is wrong. It should be Verify that it opens the Contact Support screen.
  • There is only a missing .. If you didn't do that on purpose, you can fix it and merge.
  • LGTM! 👍🏻 I'm approving.

WordPress/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Add a full stop at the end of the sentence
@ravishanker ravishanker merged commit b58b3e4 into trunk Jan 30, 2023
@ravishanker ravishanker deleted the WP-Support-forum-card-on-help-screen branch January 30, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Forum Support card on Help Screen
3 participants