-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JP Content Migration Flow] Enables Jetpack migration flow #17538
Conversation
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17538-ea0b54c.apk
|
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17538-ea0b54c.apk
|
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @antonis 🙇
I tested using the testing steps and everything works as expected.
I did notice 3 issues:
- The infinite loading migration flow when we don't open the Posts Lists in the WordPress app
- The error in the migration flow when the WordPress app is not logged in
- When logged in with self-hosted site in WordPress app, the migration flow is also stuck on the infinite loading screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further investigation the 2 issues mentioned above (1 & 3) seem very much related, and all 3 are planned to be fixed within this task:
I will merge this PR as there are no unknown issues and the happy flow works as expected 🚀 🥇
Thanks for testing this Ovi!
I agree, these are related, and handled by that task 👍 , and seem to be resolved by this: #17549 |
Fixes #17528
Description
Enables the Jetpack migration flow by flipping on the following build flags:
JETPACK_POWERED_BOTTOM_SHEET
JETPACK_SHARED_LOGIN
JETPACK_LOCAL_USER_FLAGS
JETPACK_BLOGGING_REMINDERS_SYNC
JETPACK_READER_SAVED_POSTS
JETPACK_PROVIDER_SYNC
JETPACK_MIGRATION_FLOW
Notes:
PREVENT_DUPLICATE_NOTIFS_REMOTE_FIELD
flag will be enabled with Disable notifications on WP app in migration flow on JP app #17513OPEN_WEB_LINKS_WITH_JETPACK_FLOW
flag has not been enabled with this PR (cc @zwarm)To test:
1. Testing the Jetpack powered bottom sheet
Dashboard
→Home
tabMe
Activity Log
→Activity Item Detail
Me
→App Settings
Notifications
→Notifications Settings
Sharing
Reader
→Reader Detail
Reader
listReader
→Search
(both empty and with search suggestions that show after searching once)Reader
→Search
→Search results
listNotifications
listStats
pageActivity Log
list2. Generate some local-only post/page content in the WordPress App
You could create more as described in [Jetpack Content Migration Flow] Local migration content provider #17398
3. Create some local settings
Posts
list and tap the circle icon under the←
back arrow, to filter posts by authorMe
instead ofEveryone
Me
4. Create a blogging reminder
My Site
go toMenu
→Site Settings
→Blogging Reminders
Update
My Site
toMenu
→Site Settings
→Reminders and prompts
2
exists in the Jetpack app (same day(s) selected)5. Save some reader posts
Reader
→Discover
Saved
tab to make sure you have a saved post (note it down)Reader
Note (Reader will open automatically if you left the WordPress app open on
Reader
)Saved
tabUninstall the Jetpack app or log out of Jetpack and delete all data.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
Tests where added during feature development
PR submission checklist:
RELEASE-NOTES.txt
if necessary.