Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JP Content Migration Flow] Enables Jetpack migration flow #17538

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Nov 25, 2022

Fixes #17528

Description

Enables the Jetpack migration flow by flipping on the following build flags:

  • JETPACK_POWERED_BOTTOM_SHEET
  • JETPACK_SHARED_LOGIN
  • JETPACK_LOCAL_USER_FLAGS
  • JETPACK_BLOGGING_REMINDERS_SYNC
  • JETPACK_READER_SAVED_POSTS
  • JETPACK_PROVIDER_SYNC
  • JETPACK_MIGRATION_FLOW

Notes:

To test:

1. Testing the Jetpack powered bottom sheet
  1. Launch the WordPress app
  2. Verify that the bottom sheet overlay is show when the user taps on a badge/banner in the following cases:
  • Badges:
    1. DashboardHome tab
    2. Me
    3. Activity LogActivity Item Detail
    4. MeApp Settings
    5. NotificationsNotifications Settings
    6. Sharing
    7. ReaderReader Detail
  • Banners
    1. Reader list
    2. ReaderSearch (both empty and with search suggestions that show after searching once)
    3. ReaderSearchSearch results list
    4. Notifications list
    5. Stats page
    6. Activity Log list
2. Generate some local-only post/page content in the WordPress App
  1. Install the WordPress app flavor from this branch
  2. Login to the WordPress app and select a site
  3. Publish a post
  4. Make changes to the post and do not publish them (local changes)
    You could create more as described in [Jetpack Content Migration Flow] Local migration content provider #17398
3. Create some local settings
  1. Install the WordPress app flavor from this branch
  2. Go to Posts list and tap the circle icon under the back arrow, to filter posts by author
  3. Select Me instead of Everyone
  4. After fresh installing, running the Jetpack App and completing the migration flow (main steps 6-8):
    1. Go to Posts list
    2. Verify the posts filtering by author is set to Me
4. Create a blogging reminder
  1. Install the WordPress app flavor from this branch
  2. On My Site go to MenuSite SettingsBlogging Reminders
  3. Select at least a day for blogging reminders and tap Update
  4. After fresh installing, running the Jetpack App and completing the migration flow (main steps 6-8):
    1. Go from My Site to MenuSite SettingsReminders and prompts
    2. Verify the blogging reminder set at step 2 exists in the Jetpack app (same day(s) selected)
5. Save some reader posts
  1. Install the WordPress app flavor from this branch
  2. Go to ReaderDiscover
  3. Tap the bookmark/save icon (first icon) under one post and continue on the dialog that appears
  4. Go to Saved tab to make sure you have a saved post (note it down)
  5. After fresh installing, running the Jetpack App and completing the migration flow (main steps 6-8):
    1. Go to Reader
      Note (Reader will open automatically if you left the WordPress app open on Reader)
    2. Go to Saved tab
    3. Verify The post saved at step 3 & verified at step 4 exists in the Jetpack app

Uninstall the Jetpack app or log out of Jetpack and delete all data.

  1. Run the Jetpack app from this branch
  2. Expect not see the migration flow
  3. Proceed till the end
  4. Verify that you logged in automatically and that your data are available

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    Tests where added during feature development

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 25, 2022

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17538-ea0b54c.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitea0b54c
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 25, 2022

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17538-ea0b54c.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitea0b54c
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@antonis antonis marked this pull request as ready for review November 25, 2022 14:51
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@antonis antonis requested review from RenanLukas, develric and ovitrif and removed request for RenanLukas November 25, 2022 14:53
@enejb
Copy link
Contributor

enejb commented Nov 25, 2022

I just want to make a note here that the OPEN_WEB_LINKS_WITH_JETPACK_FLOW is now on remotely. See D93523-code.

We will need to turn it off remotely as well. If we decide to revert it.

cc: @antonis and @zwarm

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @antonis 🙇

I tested using the testing steps and everything works as expected.

I did notice 3 issues:

  1. The infinite loading migration flow when we don't open the Posts Lists in the WordPress app
  2. The error in the migration flow when the WordPress app is not logged in
  3. When logged in with self-hosted site in WordPress app, the migration flow is also stuck on the infinite loading screen

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further investigation the 2 issues mentioned above (1 & 3) seem very much related, and all 3 are planned to be fixed within this task:

I will merge this PR as there are no unknown issues and the happy flow works as expected 🚀 🥇

@ovitrif ovitrif merged commit 9164dde into trunk Nov 25, 2022
@ovitrif ovitrif deleted the task/enable-jetpack-migration-flow branch November 25, 2022 21:06
@mkevins
Copy link
Contributor

mkevins commented Nov 28, 2022

Thanks for testing this Ovi!

seem very much related, and all 3 are planned to be fixed within this task:

I agree, these are related, and handled by that task 👍 , and seem to be resolved by this: #17549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - Enable Content Migration Flow
5 participants