Fix disabling create site notification issue

[irfano]

#17496 added the ability to disable create site notifications via the Notification Settings switch. But it has an issue mentioned in the PR:

Create site notifications won't be rescheduled if you turn on the switch again. Two Create site notifications are scheduled when the app is installed the first time. One is for the next day after the install, another one is for 8 days after the first install. If the switch is turned off and turned on in 8 days, create site notifications won't display. I'll discuss this later and change it in a separate PR if necessary.

This PR fixes that issue.

I removed canceling create site notifications on UpdateNotificationSettingsUseCase. It's already being handled in CreateSiteNotificationHandler when the notification is about to show. Notice the isNotificationSettingsEnabled parameter in the check.

WordPress-Android/WordPress/src/main/java/org/wordpress/android/workers/notification/createsite/CreateSiteNotificationHandler.kt

Lines 24 to 30 in 2edb3e0

	override fun shouldShowNotification(): Boolean {
	val isNotificationSettingsEnabled = sharedPrefs.getBoolean(
	resourceProvider.getString(R.string.wp_pref_notifications_main),
	true
	)
	return isNotificationSettingsEnabled && accountStore.hasAccessToken() && !siteStore.hasSite()
	}

To test:
If you want to manipulate the code to wait a minute instead of a day, change

WordPress-Android/WordPress/src/main/java/org/wordpress/android/workers/notification/createsite/CreateSiteNotificationScheduler.kt

Line 25 in 7c0348e

delayUnits = TimeUnit.DAYS,

with delayUnits = TimeUnit.MINUTES

When the switch is off

1. Uninstall the app if installed.
2. Install and launch the WordPress app.
3. Log in with an account without any site.
4. Navigate to Notifications.
5. Tap ⚙️ button at the top of the screen.
6. Turn off the switch at the top of the page.
7. Wait for the next day. Ensure the create site notification won't be delivered.

When the switch is turned off and then on again

1. Uninstall the app if installed.
2. Install and launch the WordPress app.
3. Log in with an account without any site.
4. Navigate to Notifications.
5. Tap ⚙️ button at the top of the screen.
6. Turn off the switch at the top of the page. Then turn it on again.
7. Wait for the next day. Ensure the create site notification will be delivered.

Regression Notes

1. Potential unintended areas of impact
   None.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17534-d608468.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	d608468

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17534-d608468.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	d608468

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[ravishanker]

Nice work 👍