Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack App: Fix QR Code auth flow not translated in app language #17533

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Nov 24, 2022

Fixes #17525

This quick-win fix ensures the screens in the QR code auth flow are translated in the language of the app.
Previously they were not respecting the app language.

To test:

  1. Launch Jetpack App
  2. Change the language MeApp SettingsInterface Language (e.g. Dutch)
  3. Go back, you should land on the Me screen
  4. Tap Scan Login Code (3rd item)
  5. On your computer, open a guest browser window and go to https://wordpress.com/log-in/qr
  6. Scan the QR code from your computer with the Jetpack app
  7. Expect The screens in the flow to be translated in the same language as the app

Previews

Before After
qrcodeauth_i18n_issue.mp4
qrflow_after.mp4

Regression Notes

  1. Potential unintended areas of impact
    N/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/a

  3. What automated tests I added (or what prevented me from doing so)
    N/a - Android code.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ovitrif ovitrif requested a review from zwarm November 24, 2022 16:22
@ovitrif ovitrif modified the milestones: 21.3, 21.4 Nov 24, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17533-abbec6c.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitabbec6c
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17533-abbec6c.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitabbec6c
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@AjeshRPai AjeshRPai self-requested a review November 25, 2022 09:26
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovitrif

Nice work. I tested the QR code login in English and German(Deutsch). Für mich sieht alles gut aus. 👍🏼 🟢

When language set to English When app language set to German
Screenshot_20221125-185634 Screenshot_20221125-185705
Screenshot_20221125-185638 Screenshot_20221125-185708
Screenshot_20221125-185427 Screenshot_20221125-185223

Please merge when convenient 👍🏼 🎉

@AjeshRPai AjeshRPai merged commit f543f4e into trunk Nov 25, 2022
@AjeshRPai AjeshRPai deleted the issue/17525-fix-translations-on-qrcodeauth branch November 25, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack App: Screens in the QR Code Auth flow are not translated
3 participants