Avoid truncation of 'Try Jetpack" button with big fonts #17511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17428
This PR ensures the
Try the new Jetpack app
button is not truncated with big fonts.The issue was not reproducing for all languages, one of the languages it reproduced with is
French
.I replaced the
MaterialButton
with aButton
because I couldn't find any way to make theMaterialButton
avoid truncation on the bottom sheet.To test:
Test Case 1 - Big Fonts
jetpack_powered_bottom_sheet_remote_field
feature flag.Me
→App Settings
→Interface Language
)Me
, orMy Site
→Home
Test Case 2 - Regression
Me
, orMy Site
→Home
Try the new Jetpack app
styled as before, with no visual regressionTry the new Jetpack app
styled as before, with no visual regressionTry the new Jetpack app
buttonPreviews
Regression Notes
Potential unintended areas of impact
Try Jetpack
button without big fonts - on landscape & portrait.What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/a - UI changes.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.