Make 'WordPress is better with Jetpack' bottom sheet text and button fully visible with big fonts #17503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17429
This PR fixes an issue preventing the text and button of the
WordPress is better with Jetpack
bottom sheet from being entirely visible on some devices with big fonts, by making the content of the bottom sheet scrollable.To test:
Test Case 1 - Big Fonts
jetpack_powered_bottom_sheet_remote_field
feature flag.Me
, orMy Site
→Home
Auto rotate
is enabled)Test Case 2 - Regression
Me
, orMy Site
→Home
WordPress is better with Jetpack
styled as before, with no visual regressionWordPress is better with Jetpack
styled as before, with no visual regression.Previews
Portrait
With Large Font Size
new_txl.mp4
With Default Font Size
Landscape - With Large Font Size
land_new_txl.mp4
Regression Notes
Potential unintended areas of impact
Jetpack powered bottom sheet without big fonts - on both portrait & landscape.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/a - UI changes.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.