Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats widget not loading stats activity correctly #17439

Merged

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Nov 8, 2022

Fixes #16637

This PR sets the pending intent template with FLAG_MUTABLE. This is necessary in order for widget subview click-handlers to be differentiated. This should be ok to mark mutable since this is an explicit intent.

To test:

Follow the steps in #16637 and the stats activity should open normally when tapping either the title or subviews of the stats widget.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    This is out of scope for this fix.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This is necessary in order for widget subview click-handlers to be
differentiated. This should be ok to mark mutable since this is an
explicit intent.
@mkevins mkevins marked this pull request as ready for review November 8, 2022 04:27
@mkevins mkevins requested a review from ravishanker November 8, 2022 04:28
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 8, 2022

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17439-a810f9e.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commita810f9e
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 8, 2022

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17439-a810f9e.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commita810f9e
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 🚀

@ravishanker ravishanker merged commit 915184c into trunk Nov 9, 2022
@ravishanker ravishanker deleted the issue/16637-fix-stats-widget-pending-intent-template branch November 9, 2022 01:44
@mkevins
Copy link
Contributor Author

mkevins commented Nov 9, 2022

Thank you for reviewing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on the Stats Widget after Closing the App Prompts User to Enable Site Stats Again
3 participants