Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label with the current app language to the App Settings screen #17004

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Aug 4, 2022

Fixes #16483

Shows a label with the current app language in App Settings, under "Interface Language".

To test:

  1. Open the WordPress or Jetpack app of this PR (QR-code or local build)
  2. Tap on the profile icon to open the Me page
  3. Tap App Settings
  4. Expect a label with the current language to show under "Interface Language" (in the first list item)
    Optionally:
    • Tap Interface Language and select choose another language
    • Expect the label to update and show the new language that you've selected.

Preview:

English (Day Mode) Dutch (Night Mode)
currentLang currentLangNl

Regression Notes

  1. Potential unintended areas of impact
    Language Picker.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually.

  3. What automated tests I added (or what prevented me from doing so)
    Updated LocalePickerViewModelTest unit tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ovitrif ovitrif added this to the 20.5 milestone Aug 4, 2022
@ovitrif ovitrif changed the title Issue/16483 add current locale label to appsettings Add label with the current app language to the App Settings screen Aug 4, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2022

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17004-a5985da.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2022

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17004-a5985da.apk), or scanning this QR code:

@ovitrif ovitrif requested a review from antonis August 5, 2022 06:56
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ovitrif 👍
I tested the CI build on a Pixel 5 (Android 12) and everything worked as described. The code changes also LGTM 🎉
Thank you for wrangling this 🙇

@antonis antonis merged commit 6fb4a46 into trunk Aug 5, 2022
@antonis antonis deleted the issue/16483-add-current-locale-label-to-appsettings branch August 5, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale Picker: Add secondary label with current locale in App Settings
4 participants