Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor swipeToAvoidGrayOverlay to ignore failures and become reusable #16944

Merged

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Jul 25, 2022

Fixes Random failures in the UI tests for screenshots automation. (commonly seen in wpScreenshotTests)

Refactored swipeToAvoidGrayOverlay into UiTestingUtils.swipeToAvoidGrayOverlayIgnoringFailures, reused it and made it ignore failures since it's not so critical imho.

Merging Policy Can be merged with one review.

To test:

  1. CI Checks for instrumented tests should be green 🟢.

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/a

  3. What automated tests I added (or what prevented me from doing so)
    Not applicable - changes are in UI tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ovitrif ovitrif added [Type] Enhancement UI Tests Anything related to automated UI Tests. labels Jul 25, 2022
@ovitrif ovitrif added this to the 20.5 milestone Jul 25, 2022
@ovitrif ovitrif requested review from zwarm and AjeshRPai July 25, 2022 12:02
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovitrif - nice improvement on moving that method to utils. 👏 As soon as all tests pass, it's a 👍 . Plus I've been using the same try/catch strategy to figure out a way to actually make it work to eliminate the gray screen.

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16944-33a2805.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16944-33a2805.apk), or scanning this QR code:

@AjeshRPai AjeshRPai merged commit 6ea4960 into trunk Jul 25, 2022
@AjeshRPai AjeshRPai deleted the refactor/ui-testing-swipe-to-avoid-viewpager-gray-overlay branch July 25, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement UI Tests Anything related to automated UI Tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants