-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses lint issues in AGP 7.2.1 update #16839
Addresses lint issues in AGP 7.2.1 update #16839
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16839-0e12fd6.apk), or scanning this QR code: |
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16839-0e12fd6.apk), or scanning this QR code: |
7519752
to
9988ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @oguzkocer !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟
I have left one suggestion (💡) for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.
WordPress/src/main/java/org/wordpress/android/ui/people/PeopleListFragment.java
Outdated
Show resolved
Hide resolved
|
Generated by 🚫 dangerJS |
This PR addresses the lint issues due to AGP
7.2.1
update in #16834.TextDrawable
widget, so we don't even need to fix the lint issue 🙈DividerItemDecoration
instead. Funnily enough I worked on the people list 6+ years ago andDividerItemDecoration
was not available back then (was added a few months after) so we had to build it ourselves. The difference between the regular divider and the custom divider is that the regular divider covers the whole width whereas the custom divider had some space before and after the line. See the screenshots below for comparison. Since we are using the regular divider in a lot of newer screens, this change should bring the design of people list closer to the rest of the app so it's a win-win situation.Obsolete SDK_INT version checks
lint error.Before:
(Full name and display name are removed and the screenshot was cut in half to make it easier to see)
After:
(Full name and display name are removed and the screenshot was cut in half to make it easier to see)
To test:
People
page from "My Site" -> "People" and verify that the divider looks OKRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.