Fix: Cannot choose reader topics in some languages #16789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16237
This PR fixes a bug where a valid URL encoded tag with % symbols was sanitized to remove % symbols making it an invalid URL encoded tag and causing issues in following the tag.
See #16237 (comment) for more details.
/cc @thehenrybyrd
To test:
Test.1 - Follow/ unfollow a topic in a language like Chinese (Taiwan)
device-2022-06-22-111733.mp4
Test.2 - Add a topic with invalid characters
Reader
tab, tap on theSetting
menu (⚙️ icon) on the top to open "Manage Topics & Sites" screen.device-2022-06-22-112316.mp4
Test.3 - Add a topic with spaces
Reader
tab, tap on theSetting
menu (⚙️ icon) on the top to open "Manage Topics & Sites" screen.device-2022-06-22-113057.mp4
Regression Notes
Potential unintended areas of impact
Strings that are not URL encoded should be sanitized with dashes.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually. See "To test" section.
What automated tests I added (or what prevented me from doing so)
Added string sanitization tests in
ReaderUtilsTest
.PR submission checklist:
RELEASE-NOTES.txt
if necessary.