Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Aztec version to v1.5.9 #16780

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Bump Aztec version to v1.5.9 #16780

merged 3 commits into from
Jun 23, 2022

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Jun 21, 2022 •
edited
Loading

This PR updates the version of Aztec to v1.5.9 to incorporate updates to the AztecAndroid Placeholder API.

Related PRs:

To test:

  • Verify editor works as normal.

Regression Notes

  1. Potential unintended areas of impact
    Aztec Editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    No automated tests added as we have deprecated the Aztec Editor.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@derekblank derekblank requested a review from geriux June 21, 2022 05:28
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 21, 2022 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@derekblank
Copy link
Contributor Author

@geriux My understanding is that this PR will also need to bump the gutenbergMobileVersion in build.gradle, too. Currently it is pointing at the 1.78.1 release. Based on looking at previous Aztec version bumps, should this version number be arbitrarily updated to the next alpha version (i.e., 1.78.2-alpha1), or wait to be updated until the gutenberg-mobile PRs have been merged?

@derekblank
Copy link
Contributor Author

derekblank commented Jun 21, 2022 •
edited
Loading

@planarvoid I added basic testing instructions and regression notes regarding testing the Aztec changes -- let me know if anything else regarding the Placeholder API should be added for testing or regression review. 🙇

@geriux
Copy link
Contributor

geriux commented Jun 21, 2022

Based on looking at previous Aztec version bumps, should this version number be arbitrarily updated to the next alpha version (i.e., 1.78.2-alpha1), or wait to be updated until the gutenberg-mobile PRs have been merged?

We should merge first the Gutenberg PR, then continue with the Gutenberg Mobile PR, create an alpha tag e.g. v1.79.0-alpha1 and finally update this PR with it before merging. Before doing so we should check if we are doing a release anytime soon or not because once an alpha tag is merged, it gets complicated if we are skipping a release 😅 . If we skip a release we could create an after branch to merge this PR.

@geriux
Copy link
Contributor

geriux commented Jun 21, 2022

It looks like the CI checks are failing because we need to point to the Guteberg mobile commit that has the Aztec update.

@geriux geriux mentioned this pull request Jun 21, 2022
Closed
@derekblank derekblank mentioned this pull request Jun 22, 2022
Merged
2 tasks
@derekblank derekblank changed the base branch from trunk to gutenberg/after_1.79.0 June 22, 2022 08:27
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 22, 2022 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@derekblank
Copy link
Contributor Author

It looks like the CI checks are failing because we need to point to the Guteberg mobile commit that has the Aztec update.

@geriux Thanks -- I've created the 1.79.0-alpha1 (which is pointing at the updated AztecAndroid v1.5.9), and updated the gutenberg ref in this PR. Let me know if you happen to note anything unusual with the BuildKite failures above. Clicking the "Details" link for each of the failures results in "Page Not Found" on BuildKite for me. Perhaps you can let me know if they need to be triggered to re-run some other way? If not, it may be an actual failure and I can look into that.

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor:WordPressEditor
-     +--- org.wordpress:aztec:{strictly v1.5.8} -> v1.5.8
+     +--- org.wordpress:aztec:{strictly v1.5.9} -> v1.5.9
-     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.5.8} -> v1.5.8
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-     |    +--- org.wordpress:aztec:v1.5.8 (*)
-     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
+     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.5.9} -> v1.5.9
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+     |    +--- org.wordpress:aztec:v1.5.9 (*)
+     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
-     +--- org.wordpress.aztec:wordpress-comments:{strictly v1.5.8} -> v1.5.8
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-     |    +--- org.wordpress:aztec:v1.5.8 (*)
-     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-     |    \--- com.google.android.material:material:1.0.0 -> 1.6.0-alpha01 (*)
+     +--- org.wordpress.aztec:wordpress-comments:{strictly v1.5.9} -> v1.5.9
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+     |    +--- org.wordpress:aztec:v1.5.9 (*)
+     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+     |    \--- com.google.android.material:material:1.0.0 -> 1.6.0-alpha01 (*)
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.78.1
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.1
-          |    |    +--- com.facebook.soloader:annotation:0.10.1
-          |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0
-          |         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0
-          |         |    |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
-          |         |    |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
-          |         |    +--- com.facebook.soloader:annotation:0.10.1
-          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |         |    \--- com.facebook.fresco:fbcore:2.5.0
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0
-          |         |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |         |    +--- com.facebook.soloader:annotation:0.10.1
-          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |         |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    \--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0
-          |         |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-          |         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |         |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-          |         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:ui-common:2.5.0
-          |         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    \--- com.facebook.fresco:middleware:2.5.0
-          |         |    |         +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-          +--- com.facebook.react:react-native:0.66.2
-          |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0 (*)
-          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
-          |    +--- javax.inject:javax.inject:1
-          |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-          |    +--- androidx.autofill:autofill:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    +--- com.facebook.fresco:fresco:2.5.0
-          |    |    +--- com.facebook.fresco:soloader:2.5.0
-          |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-          |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    +--- com.facebook.fresco:drawee:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
-          |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-          |    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
-          |    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-          |    |         +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    |         \--- com.facebook.fresco:fbcore:2.5.0
-          |    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
-          |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
-          |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |    +--- com.facebook.soloader:soloader:0.10.1 (*)
-          |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    +--- com.squareup.okhttp3:okhttp:4.9.1 -> 4.9.2 (*)
-          |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.1 -> 4.9.2 (*)
-          |    +--- com.squareup.okio:okio:2.9.0 (*)
-          |    \--- com.facebook.fbjni:fbjni-java-only:0.2.2
-          |         \--- com.facebook.soloader:nativeloader:0.10.1
-          +--- org.wordpress-mobile:react-native-svg:9.13.6
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-2
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-2
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-get-random-values:1.4.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-masked-view:0.2.6
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-screens:2.9.0
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
-          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-          +--- org.wordpress-mobile:react-native-safe-area-context:3.2.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-3
-          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
-          +--- org.wordpress-mobile:react-native-webview:11.6.2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
-          +--- org.wordpress-mobile:react-native-clipboard:1.9.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-1
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.4.1-wp-3
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.78.1
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- org.wordpress:aztec:v1.5.8 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.5.8 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.5.8 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.5.8
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-          |    |    +--- org.wordpress:aztec:v1.5.8 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.11.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-          +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-          \--- org.wordpress-mobile:hermes-release-mirror:0.66.2
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.79.0-alpha1
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.1
+          |    |    +--- com.facebook.soloader:annotation:0.10.1
+          |    |    \--- com.facebook.soloader:nativeloader:0.10.1
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0
+          |         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0
+          |         |    |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
+          |         |    |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
+          |         |    +--- com.facebook.soloader:annotation:0.10.1
+          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |         |    \--- com.facebook.fresco:fbcore:2.5.0
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0
+          |         |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |         |    +--- com.facebook.soloader:annotation:0.10.1
+          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |         |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    \--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0
+          |         |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
+          |         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |         |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1
+          |         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:ui-common:2.5.0
+          |         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    \--- com.facebook.fresco:middleware:2.5.0
+          |         |    |         +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+          +--- com.facebook.react:react-native:0.66.2
+          |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0 (*)
+          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
+          |    +--- javax.inject:javax.inject:1
+          |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
+          |    +--- androidx.autofill:autofill:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    +--- com.facebook.fresco:fresco:2.5.0
+          |    |    +--- com.facebook.fresco:soloader:2.5.0
+          |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
+          |    |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    +--- com.facebook.fresco:drawee:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
+          |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+          |    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
+          |    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
+          |    |         +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    |         \--- com.facebook.fresco:fbcore:2.5.0
+          |    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
+          |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
+          |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |    +--- com.facebook.soloader:soloader:0.10.1 (*)
+          |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    +--- com.squareup.okhttp3:okhttp:4.9.1 -> 4.9.2 (*)
+          |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.1 -> 4.9.2 (*)
+          |    +--- com.squareup.okio:okio:2.9.0 (*)
+          |    \--- com.facebook.fbjni:fbjni-java-only:0.2.2
+          |         \--- com.facebook.soloader:nativeloader:0.10.1
+          +--- org.wordpress-mobile:react-native-svg:9.13.6
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-2
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-2
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-get-random-values:1.4.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-masked-view:0.2.6
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-screens:2.9.0
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
+          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+          +--- org.wordpress-mobile:react-native-safe-area-context:3.2.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-3
+          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
+          +--- org.wordpress-mobile:react-native-webview:11.6.2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
+          +--- org.wordpress-mobile:react-native-clipboard:1.9.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-1
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.4.1-wp-3
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.79.0-alpha1
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- org.wordpress:aztec:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.5.9
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+          |    |    +--- org.wordpress:aztec:v1.5.9 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.11.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+          \--- org.wordpress-mobile:hermes-release-mirror:0.66.2

Please review and act accordingly

@geriux geriux force-pushed the aztec/update-aztec-placeholder-api branch from 83974c5 to ec2a7a4 Compare June 22, 2022 13:21
@geriux
Copy link
Contributor

geriux commented Jun 22, 2022

Clicking the "Details" link for each of the failures results in "Page Not Found" on BuildKite for me. Perhaps you can let me know if they need to be triggered to re-run some other way? If not, it may be an actual failure and I can look into that.

So there was an error about a missing implementation, more speficially beforeMediaDeleted that was added in Aztec. I updated the code to include it, let's see if buildkite success this time. If it does, would you mind giving it another test to check if all works ok? I did some testing and it's working fine but another would be good. Thank you!

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16780-ec2a7a4.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16780-ec2a7a4.apk), or scanning this QR code:

@derekblank
Copy link
Contributor Author

derekblank commented Jun 23, 2022 •
edited
Loading

@geriux Yep, my testing was good too, and it looks like buildkite is succeeding. Thanks for all of the testing and review! I see that review approval is not required to merge, but I just wanted to double-check that that would be ok to self-merge before I do so. (I can also wait for approval of course, just curious what typically happens for WPAndroid.) 🙇

geriux
geriux approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@geriux
Copy link
Contributor

geriux commented Jun 23, 2022

just curious what typically happens for WPAndroid.

We usually wait for an approval yes, just approved it! 🚀

@derekblank derekblank merged commit 2679fe1 into gutenberg/after_1.79.0 Jun 23, 2022
@derekblank derekblank deleted the aztec/update-aztec-placeholder-api branch June 23, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Aztec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekblank @geriux @wpmobilebot