Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Revamp v2: Feature Announcement #16703

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Jun 3, 2022

This PR adds feature announcement for Stats Revamp v2.

Fixes #16686

NOTE:

  • At the moment it is set up to show up at app launch if local debug feature flag is enabled

TODO:

  • Replace the image with properly exported one
  • Confirm what and when should invoke this on release
Detail screen with date selector

To test:

Setup:

  1. Go to App Settings (Tap on Avatar at the top right hand corner on My Site -> Find App Settings)
  2. Select Debug Settings
  3. Find StatsRevampV2FeatureConfig under Features in development enable it and restart app
  4. Launch / Re-Launch app

Test:

  • Notice the new Feature announcement dialog pops up.
  • Tap on [Try it now] and ensure it opens Stats
  • Relaunch or Return Feature announcement
  • Tap on [Remind me later] and it should dismiss the dialog
  • Relaunch or Return Feature announcement
  • Tap on X on top right hand corner and it should dismiss the dialog

To test:

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the paths

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ravishanker ravishanker added this to the 20.1 milestone Jun 3, 2022
@ravishanker ravishanker requested a review from irfano June 3, 2022 13:32
@ravishanker ravishanker self-assigned this Jun 3, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 3, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 3, 2022

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the design should be prompt popups, like blogging reminders popups.
  • We can use Hilt for StatsNewFeaturesIntroDialogFragment and StatsNewFeatureIntroViewModel. I can update it in this PR if you like, let me know.
  • I couldn't see a bulb at the top and there is divider line above buttons. Did you use a different version design file?

image

@ravishanker
Copy link
Contributor Author

  • I think the design should be prompt popups, like blogging reminders popups.

That was in i1 of the design. Latest i5 iteration is based on feature intro feature from blogging prompts

* We can use Hilt for `StatsNewFeaturesIntroDialogFragment` and `StatsNewFeatureIntroViewModel`. I can update it in this PR if you like, let me know.

I did try that, given WPMainActivity is still in Java. If you can make it work, would be great! thanks

* I couldn't see a bulb at the top and there is divider line above buttons. Did you use a different version design file?

It is not in the design, but in the feature intro design

@ravishanker ravishanker requested a review from irfano June 7, 2022 12:28
@spencertransier spencertransier modified the milestones: 20.1, 20.2 Jun 13, 2022
@spencertransier
Copy link
Contributor

Hello! Just letting you know I am moving this to the 20.2 milestone while running the code freeze for 20.1 today.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that, given WPMainActivity is still in Java.

@ravishanker I added AndroidEntryPoint to WPMainActivity, then migrate StatsNewFeaturesIntroDialogFragment to the Hilt. 427319b

It's up to you to implement the final decision on the logic in this PR or a separate one. I'm approving the current changes. 👍🏻

I think we're good to merge after resolving the conflict. But also let's follow this thread for analytics change. Internal Slack ref: p1655236755558709/1654082772.152509-slack-C02QANACA

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16703-65600eb.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16703-65600eb.apk), or scanning this QR code:

@ravishanker ravishanker merged commit b652d82 into trunk Jun 15, 2022
@ravishanker ravishanker deleted the Stats-Revamp-v2-New-Features-Announcement branch June 15, 2022 06:13
@irfano irfano added Stats and removed Stats Revamp labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[android] Stats: Feature Announcement
4 participants