-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats Revamp v2: Feature Announcement #16703
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the design should be prompt popups, like blogging reminders popups.
- We can use Hilt for
StatsNewFeaturesIntroDialogFragment
andStatsNewFeatureIntroViewModel
. I can update it in this PR if you like, let me know. - I couldn't see a bulb at the top and there is divider line above buttons. Did you use a different version design file?
That was in i1 of the design. Latest i5 iteration is based on feature intro feature from blogging prompts
I did try that, given WPMainActivity is still in Java. If you can make it work, would be great! thanks
It is not in the design, but in the feature intro design |
Hello! Just letting you know I am moving this to the 20.2 milestone while running the code freeze for 20.1 today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try that, given WPMainActivity is still in Java.
@ravishanker I added AndroidEntryPoint
to WPMainActivity
, then migrate StatsNewFeaturesIntroDialogFragment
to the Hilt. 427319b
It's up to you to implement the final decision on the logic in this PR or a separate one. I'm approving the current changes. 👍🏻
I think we're good to merge after resolving the conflict. But also let's follow this thread for analytics change. Internal Slack ref: p1655236755558709/1654082772.152509-slack-C02QANACA
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16703-65600eb.apk), or scanning this QR code: |
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16703-65600eb.apk), or scanning this QR code: |
This PR adds feature announcement for Stats Revamp v2.
Fixes #16686
NOTE:
TODO:
To test:
Setup:
Test:
To test:
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the paths
What automated tests I added (or what prevented me from doing so)
Existing unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.