Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: Adjust QS focus points for Stats and Pages #16338

Merged
merged 9 commits into from
Apr 15, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Apr 15, 2022

Parent #16301

This PR removes focus points for Stats and Pages from Quick Links Card, Quick Links Ribbon, and displays them on rows (similar to iOS).
Internal Ref: p1649763254844489/1649694944.738209-slack-C0290FLA0RM

/cc @tiagomar

To test:

Test: QS Task: Edit your homepage

Prerequisite: Initial Tab: Home

  1. Launch the app.
  2. Select Customize your site in the Next Steps card.
  3. Select Edit your homepage.
  4. ❌ Notice that QS focus point is not shown on Quick Links -> Pages.
  5. ✅ Notice that "Tap Menu to Continue" snackbar is shown with focus point on Menu tab.
  6. Click Menu tab.
  7. ✅ Notice that
    • Select pages to see your list snackbar is shown
    • QS focus point is shown on Pages site item
  8. Click Pages list item.
  9. ✅ Notice that QS focus point and snackbar is shown on the Homepage list item on Pages screen.

Repeat above steps for Initial Tab: Menu test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.

Test: QS Task: Review site pages

Prerequisite: Initial Tab: Home

  1. Launch the app.
  2. Select Customize your site in the Next Steps card.
  3. Select Review site pages.
  4. ❌ Notice that QS focus point is not shown on Quick Links -> Pages.
  5. ✅ Notice that "Tap Menu to Continue" snackbar is shown with focus point on Menu tab.
  6. Click Menu tab.
  7. ✅ Notice that
    • Select pages to see your list snackbar is shown
    • QS focus point is shown on Pages site item
  8. Click Pages list item.
  9. ✅ Notice that Pages screen is opened.

Repeat above steps for Initial Tab: Menu test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.

Test: QS Task: Check your stats

Prerequisite: Initial Tab: Home

  1. Launch the app.
  2. Select Grow your audience in the Next Steps card.
  3. Select `Check your stats.
  4. ❌ Notice that QS focus point is not shown on Quick Links -> Stats.
  5. ✅ Notice that "Tap Menu to Continue" snackbar is shown with focus point on Menu tab.
  6. Click Menu tab.
  7. ✅ Notice that
    • Tap Stats to see how your stats are performing. snackbar is shown.
    • QS focus point is shown on Stats list item.
  8. Click Stats list item.
  9. ✅ Notice that Stats screen is opened.

Repeat above steps for Initial Tab: Menu test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.

Test: Without Tabs

  • Disable the tabs feature from Debug Settings and restart the app.
  • Repeat the above tests and confirm that focus points are displayed correctly on Stats and Pages list items. Note that Site Menu Step (step 5, 6 in tests) will not be shown when tabs are disabled.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

ashiagr added 8 commits April 15, 2022 13:14
…wInSiteMenu()

This is done as these tasks now point to site list items available on the site menu tab and require site menu step similar to other qs tasks for site list items.
…tats, edit home page and review pages

Everytime tests are run, a random site menu task is selected for various site menu step tests under QUICK START REQUEST SITE MENU STEP block heading. This covers scenarios that site menu step is shown for stats, edit home page and review pages qs tasks.
@ashiagr ashiagr added this to the 19.7 milestone Apr 15, 2022
@ashiagr ashiagr self-assigned this Apr 15, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 15, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ashiagr ashiagr added Tooling and removed Tooling labels Apr 15, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 15, 2022

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr requested a review from zwarm April 15, 2022 09:52
@ashiagr ashiagr marked this pull request as ready for review April 15, 2022 10:11
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiagr - QS is always challenging, so thanks for making this one easy to review. All works as expected. The focus point shows on the Menu tab and snackbars show as expected.

As discussed, please consider adding a line item to the next project to collapse the site header after the tab has been tapped. Not a blocker for this PR at all.

@zwarm zwarm merged commit 4829149 into trunk Apr 15, 2022
@zwarm zwarm deleted the issue/16301-adjust-qs-focus-points-for-stats-and-pages branch April 15, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants