-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Site Dashboard: Adjust QS focus points for Stats and Pages #16338
My Site Dashboard: Adjust QS focus points for Stats and Pages #16338
Conversation
…wInSiteMenu() This is done as these tasks now point to site list items available on the site menu tab and require site menu step similar to other qs tasks for site list items.
…tats, edit home page and review pages Everytime tests are run, a random site menu task is selected for various site menu step tests under QUICK START REQUEST SITE MENU STEP block heading. This covers scenarios that site menu step is shown for stats, edit home page and review pages qs tasks.
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashiagr - QS is always challenging, so thanks for making this one easy to review. All works as expected. The focus point shows on the Menu tab and snackbars show as expected.
As discussed, please consider adding a line item to the next project to collapse the site header after the tab has been tapped. Not a blocker for this PR at all.
Parent #16301
This PR removes focus points for
Stats
andPages
fromQuick Links Card
,Quick Links Ribbon
, and displays them on rows (similar to iOS).Internal Ref: p1649763254844489/1649694944.738209-slack-C0290FLA0RM
/cc @tiagomar
To test:
Test: QS Task: Edit your homepage
Prerequisite: Initial Tab: Home
Customize your site
in theNext Steps
card.Edit your homepage
.Quick Links
->Pages
.Menu
tab.Menu
tab.Select pages to see your list
snackbar is shownPages
site itemPages
list item.Homepage
list item onPages
screen.Repeat above steps for
Initial Tab: Menu
test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.Test: QS Task: Review site pages
Prerequisite: Initial Tab: Home
Customize your site
in theNext Steps
card.Review site pages
.Quick Links
->Pages
.Menu
tab.Menu
tab.Select pages to see your list
snackbar is shownPages
site itemPages
list item.Pages
screen is opened.Repeat above steps for
Initial Tab: Menu
test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.Test: QS Task: Check your stats
Prerequisite: Initial Tab: Home
Grow your audience
in theNext Steps
card.Quick Links
->Stats
.Menu
tab.Menu
tab.Tap Stats to see how your stats are performing.
snackbar is shown.Stats
list item.Stats
list item.Stats
screen is opened.Repeat above steps for
Initial Tab: Menu
test skipping steps 5, 6 and confirm that focus points are displayed correctly on Stats and Pages list items.Test: Without Tabs
Site Menu Step
(step 5, 6 in tests) will not be shown when tabs are disabled.Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.