Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track events for quick link ribbon #16284

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

AjeshRPai
Copy link
Contributor

Fixes #16272

This PR adds the support for tracking events when tapping the quick link ribbon buttons. Pages/Posts/Media/Stats

Note: Only 1 approval is needed. Thanks

To test:

  • Launch the app
  • Navigate to Me -> App Settings -> Debug Settings
  • Enable MySiteDashboardTabsFeatureConfig and restart the app
  • Navigate to My Site View
  • Tap on the following (returning back to My Site View after each click):
    • All Quick Link buttons (Stats, Pages, Posts, and Media)
  • Swipe down on the My Site View to request a pull-to-refresh
  • View the logs and note that "tab_source=dashboard" is included in the properties of the track event.
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"pages"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"posts"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"media"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"stats"}

Regression Notes

  1. Potential unintended areas of impact
    Events for quick link ribbon buttons are not tracked.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual tests and Unit tests

  3. What automated tests I added (or what prevented me from doing so)
    Added tests in MySiteViewModelTest.kt

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@AjeshRPai AjeshRPai added this to the 19.7 milestone Apr 8, 2022
@AjeshRPai AjeshRPai requested review from zwarm and ashiagr April 8, 2022 09:24
@AjeshRPai AjeshRPai self-assigned this Apr 8, 2022
@AjeshRPai AjeshRPai linked an issue Apr 8, 2022 that may be closed by this pull request
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2022

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr self-assigned this Apr 8, 2022
@ashiagr ashiagr removed the request for review from zwarm April 8, 2022 10:46
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these trackings, @AjeshRPai! I can confirm that events are tracked as described:

🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"pages"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"posts"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"media"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"stats"}

But I left one question on the test cases. Lmkwyt.

Base automatically changed from issue/16227-quickstart-focus-point-change-to-quick-link-ribbon to trunk April 8, 2022 12:03
@ashiagr ashiagr self-requested a review April 8, 2022 13:27
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@ashiagr ashiagr merged commit 521e6b3 into trunk Apr 8, 2022
@ashiagr ashiagr deleted the issue/16272-add-track-events-for-quick-link-ribbon branch April 8, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add track events for Quick Link ribbon
2 participants