-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track events for quick link ribbon #16284
Add track events for quick link ribbon #16284
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these trackings, @AjeshRPai! I can confirm that events are tracked as described:
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"pages"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"posts"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"media"}
🔵 Tracked: quick_action_ribbon_tapped, Properties: {"default_tab_experiment":"nonexistent","tab_source":"dashboard","button":"stats"}
But I left one question on the test cases. Lmkwyt.
WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #16272
This PR adds the support for tracking events when tapping the quick link ribbon buttons. Pages/Posts/Media/Stats
Note: Only 1 approval is needed. Thanks
To test:
Regression Notes
Potential unintended areas of impact
Events for quick link ribbon buttons are not tracked.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual tests and Unit tests
What automated tests I added (or what prevented me from doing so)
Added tests in
MySiteViewModelTest.kt
PR submission checklist:
RELEASE-NOTES.txt
if necessary.