Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: Tabs - Add release notes #16269

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Apr 6, 2022

Parent #15989

This PR adds release notes for the My Site Dashboard tabs feature

cc: @AliSoftware I'm not sure if the length is too long; but if it is, we can cut it down to My Site: your My Site screen now has two tabs, "Site Menu" and "Home". LMK. Thanks

To test:
There is nothing to test for this PR.

Regression Notes

  1. Potential unintended areas of impact N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on) N/A
  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 19.7 milestone Apr 6, 2022
@zwarm zwarm requested a review from ashiagr April 6, 2022 15:28
@zwarm zwarm self-assigned this Apr 6, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Apr 6, 2022
28 tasks
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@AliSoftware
Copy link
Contributor

AliSoftware commented Apr 6, 2022

cc: @AliSoftware I'm not sure if the length is too long; but if it is, we can cut it down to My Site: your My Site screen now has two tabs, "Site Menu" and "Home". LMK. Thanks

@zwarm Thanks for the consideration about this!

The RELEASE-NOTES.txt file is there to host the "developer-oriented" release notes. Those are then always reworked by our freelance writer (see the #wordpress-release-notes channel in our Slack) once we do the code freeze, to produce a more user-oriented, editorialized release notes copy (see how it recently happened during 19.6's code freeze in this PR for example). Our writer then knows about the character limit for Android's release notes on PlayStore, so she'll take this into consideration at the time 19.7 is cut and we ask her to transform those notes to a nice copy for 19.7 in 2 weeks. 😉

That being said, thanks for pointing this out. The alternate title you mentioned could for example be a starting point for our freelance writer to know how to formulate the wording about this item in a more concise manner if the notes end up too packed after more features land for 19.7 during this sprint and she need to use some conciseness 👍

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ashiagr ashiagr merged commit 6a405f3 into trunk Apr 7, 2022
@ashiagr ashiagr deleted the issue/15989-MySiteDashboardTabs-add-release-notes branch April 7, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants