Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: Initial Screen App Setting #16252

Merged
merged 8 commits into from
Apr 5, 2022

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Apr 4, 2022

Parent #15989

This PR adds the “initial screen” setting to the App Settings view. The setting is only visible when tabs are enabled for My Site Dashboard. This setting will persist until the app is uninstalled/reinstalled - similar to other device app settings.

Merge Instructions

  • You can review, but not merge this PR yet. I am waiting on some verifications from the iOS team with regards to what the default value should be for the setting. I will review the "do not merge label" after the direction has been clarified.

To test
Do a clean install of the app and don't enable the MySiteDashboardTabsFeatureConfig flag. Then:

  1. Login or create a new account
  2. Navigate to Me → App Settings
  3. Note: You don’t see an "Initial Screen" option
  4. Navigate to Me → App Settings → Debug
  5. Enable the MySiteDashboardTabsFeatureConfig flag and restart the App
  6. When the app has restarted, Navigate to Me → App Settings
  7. Note: You see an "Initial Screen" option
  8. Change the value
  9. Make sure that an event is fired on the console, like: 🔵 Tracked: app_settings_initial_screen_changed, Properties: {"default_tab_experiment":"site_menu","selected":"site_menu"}
  10. Close and reopen the app
  11. Navigate back to Me → App Settings
  12. Note: The option you selected is now the default

Regression Notes

  1. Potential unintended areas of impact
    The app setting does not show or hide the initial screen setting

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual test

  3. What automated tests I added (or what prevented me from doing so)
    There are no unit tests for the AppSettingsFragment.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 4, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 4, 2022

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, @zwarm. 👍 I just left one comment. I'll wait to review till further implementation.

WordPress/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@ashiagr ashiagr self-requested a review April 5, 2022 12:01
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Feel free to merge it when CI is done.

@zwarm zwarm merged commit beed7aa into trunk Apr 5, 2022
@zwarm zwarm deleted the issue/15989-msd-initial-tab-setting branch April 5, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants