-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Site Dashboard: Initial Screen App Setting #16252
Conversation
… and removing the pref if my site tabs is not enabled
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, @zwarm. 👍 I just left one comment. I'll wait to review till further implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Feel free to merge it when CI is done.
Parent #15989
This PR adds the “initial screen” setting to the App Settings view. The setting is only visible when tabs are enabled for My Site Dashboard. This setting will persist until the app is uninstalled/reinstalled - similar to other device app settings.
Merge Instructions
To test
Do a clean install of the app and don't enable the MySiteDashboardTabsFeatureConfig flag. Then:
🔵 Tracked: app_settings_initial_screen_changed, Properties: {"default_tab_experiment":"site_menu","selected":"site_menu"}
Regression Notes
Potential unintended areas of impact
The app setting does not show or hide the initial screen setting
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual test
What automated tests I added (or what prevented me from doing so)
There are no unit tests for the AppSettingsFragment.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.