Fix: Quick Start Prompt not shown on API 25 #16238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16225
This PR adds a quick fix for the issue where we noticed that the order of nested child fragments creation/parent fragment result handling is different between different Android versions (as a result QS prompt was not shown after the
Login Epilogue
was dismissed) by adding a small delay before passing the result to nested child fragments.(Internal Slack Ref: p1648794037279879-slack-C02QANACA)
It might not be a real issue as we could verify the issue only on a lower API level emulator but this workaround takes care of the scenario if it actually happens.
To test:
To be safe, test it on a higher API level emulator/ device as well.
Regression Notes
Potential unintended areas of impact
Other activity result scenarios like site icon change, stories photo picker should work as intended.
Note that I also tried passing data from parent to child fragment using a shared parent fragment VM (in this branch) but the site icon change was broken with this approach.
We might want to find a better way so that we don't have to add even this small delay but considering time constraints and that the delay added is negligible, the workaround serves the purpose.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.