Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: Tabs - Track default tab experiment variant assigned #16187

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Mar 28, 2022

Parent #15989

This PR tracks MY_SITE_DEFAULT_TAB_EXPERIMENT_VARIANT_ASSIGNED when the value is set. This is needed because the "signed_in" event is called from LoginAnalyticsTracker and we shouldn't be injecting logic for setting the experiment variant in a tracker. Thus we set the variant in LoginEpilogue, but the signed_in events have already been tracked at this point. This event will give us a starting point for funnels following a sign up or login.

To test:
Test A: Login

  • Launch the app
  • If not enabled, please enable MySiteDashboardTabsFeatureConfig, then restart the app and logout
  • Login
  • Verify the logs contain: (the default can be dashboard or site_menu)
    🔵 Tracked: my_site_default_tab_experiment_variant_assigned, Properties: {"default_tab_experiment":"dashboard"}

Test B: Signup

  • Launch the app
  • If not enabled, please enable MySiteDashboardTabsFeatureConfig, then restart the app and logout
  • Signup with a new account
  • Verify the logs contain: (the default can be dashboard or site_menu)
    🔵 Tracked: my_site_default_tab_experiment_variant_assigned, Properties: {"default_tab_experiment":"dashboard"}

Regression Notes

  1. Potential unintended areas of impact
    The event is not tracked

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing & unit testing

  3. What automated tests I added (or what prevented me from doing so)
    Added two new tests to MySiteDefaultTabExperimentTest

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

FYI: @leandroalonso

@zwarm zwarm added this to the 19.6 milestone Mar 28, 2022
@zwarm zwarm requested a review from AjeshRPai March 28, 2022 15:02
@zwarm zwarm self-assigned this Mar 28, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Mar 28, 2022
13 tasks
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code changes and tested it as per the instructions. Everything looks good to me. @zwarm . 👍 🙌

@zwarm zwarm merged commit 7b3e33d into trunk Mar 29, 2022
@zwarm zwarm deleted the issue/16007-track-variant-assigned branch March 29, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants