My Site Dashboard: Tabs - Track default tab experiment variant assigned #16187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #15989
This PR tracks
MY_SITE_DEFAULT_TAB_EXPERIMENT_VARIANT_ASSIGNED
when the value is set. This is needed because the "signed_in" event is called fromLoginAnalyticsTracker
and we shouldn't be injecting logic for setting the experiment variant in a tracker. Thus we set the variant inLoginEpilogue
, but the signed_in events have already been tracked at this point. This event will give us a starting point for funnels following a sign up or login.To test:
Test A: Login
🔵 Tracked: my_site_default_tab_experiment_variant_assigned, Properties: {"default_tab_experiment":"dashboard"}
Test B: Signup
🔵 Tracked: my_site_default_tab_experiment_variant_assigned, Properties: {"default_tab_experiment":"dashboard"}
Regression Notes
Potential unintended areas of impact
The event is not tracked
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing & unit testing
What automated tests I added (or what prevented me from doing so)
Added two new tests to MySiteDefaultTabExperimentTest
PR submission checklist:
RELEASE-NOTES.txt
if necessary.FYI: @leandroalonso