-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Site Dashboard: Tabs - Track experiment property with all events #16183
Conversation
… is present (not null) and has properties to inject.
… helper functions.
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
👋 @zwarm I found property It was only these login events which did not have the right variant, but it is something you already know and discussed in our call today: 🔵 Tracked: signed_in, Properties: {"dotcom_user":true,"default_tab_experiment":"nonexistent"} I'll approve and merge this PR and let you work on the remaining metrics stuff. |
Parent #16007
This PR adds support for tracking My Site Default Tab Experiment properties with every event tracked (when the experiment is running)
The following property is tacked on to every event
default_tab_experiment
values =dashboard|site_menu|nonexistent
I tried to keep this as generic as possible and not pollute the "tracker" with references to "MySIteDashboard".
Merge Instructions
PR My Site Dashboard: Tabs Add feature flags for default tab experiment #16175 and My Site Dashboard: Tabs - Assign default tab variant and save to app prefs #16176 have been merged- Remove the Not Ready for Merge labelTo test:
MySiteDashboardTabsFeatureConfig
, then restart the app and logoutmy_site_default_tab_experiment
and restart the appRegression Notes
Potential unintended areas of impact
Events are not tracked
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual and unit testing
What automated tests I added (or what prevented me from doing so)
Add unit tests to
MySiteDefaultTabExperimentTest
PR submission checklist:
RELEASE-NOTES.txt
if necessary.