Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: Tabs - Track experiment property with all events #16183

Merged
merged 6 commits into from
Mar 28, 2022

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Mar 27, 2022

Parent #16007

This PR adds support for tracking My Site Default Tab Experiment properties with every event tracked (when the experiment is running)
The following property is tacked on to every event
default_tab_experiment values =dashboard|site_menu|nonexistent

I tried to keep this as generic as possible and not pollute the "tracker" with references to "MySIteDashboard".

Merge Instructions

To test:

  • Launch the app and Login
  • If not enabled, please enable MySiteDashboardTabsFeatureConfig, then restart the app and logout
  • Login
  • Navigate to My Site
  • View the logs and note that you see property "default_tab_experiment" being tracked on all events
  • Navigate to Me -> App Settings -> Debug Settings
  • Disable my_site_default_tab_experiment and restart the app
  • View the logs and note that you don't see property "default_tab_experiment" being tracked

Regression Notes

  1. Potential unintended areas of impact
    Events are not tracked

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual and unit testing

  3. What automated tests I added (or what prevented me from doing so)
    Add unit tests to MySiteDefaultTabExperimentTest

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 27, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Mar 27, 2022
13 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 27, 2022

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr
Copy link
Contributor

ashiagr commented Mar 28, 2022

👋 @zwarm

I found property default_tab_experiment getting tracked for all events when MySiteDashboardTabsFeatureConfig was enabled as described. 👍

It was only these login events which did not have the right variant, but it is something you already know and discussed in our call today:

🔵 Tracked: signed_in, Properties: {"dotcom_user":true,"default_tab_experiment":"nonexistent"}
🔵 Tracked: login_social_success, Properties: {"default_tab_experiment":"nonexistent"}

I'll approve and merge this PR and let you work on the remaining metrics stuff.

@ashiagr ashiagr merged commit ef5c374 into trunk Mar 28, 2022
@ashiagr ashiagr deleted the issue/16007-track-default-tab-experiment-all branch March 28, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants