-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save media capture path during orientation changes #16037
Save media capture path during orientation changes #16037
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mkevins !
Thank you for fixing this 🙇♂️
The code changes LGTM & the fix is working as expected ✅
I'll go ahead and merge the pull request 🚀
@mkevins I merged latest Let me know if you'd prefer that I don't do this, for me it's "collaboration" but I want to develop the right sensitivity to how such contributions are seen. I already checked with the team lead but I also need your feedback 🙇♂️ I'll leave the PR as Thank you |
Thanks Ovi, this is fine, especially since I believe the conflict was only in the release notes. Thanks for reviewing and testing 👍 |
Fixes #11296
Description
This PR saves the media capture path when the activity is destroyed, and restores it when it is recreated. This allows the processing of a captured photo to resume when the activity returns to the foreground after an orientation change has taken place. See #11296 (comment) for more details.
To test:
The photo should upload and be displayed correctly in the editor.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.