Issue/remove nested comments when removing parent #15993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we handled orphaned comments in the way that is consistent with previous versions of the app.
We tried to show orphaned comments when the parent is removed, but this approach is not very compatible with paging, and causes more troubles than benefits.
After PR the orphaned comments will be hidden. Removing the parent comment will also remove nested comments.
To test:
Regression Notes
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
Legacy code is not very testable.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.