Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/remove nested comments when removing parent #15993

Merged
merged 7 commits into from
Feb 25, 2022

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Feb 23, 2022

This PR changes the way we handled orphaned comments in the way that is consistent with previous versions of the app.

We tried to show orphaned comments when the parent is removed, but this approach is not very compatible with paging, and causes more troubles than benefits.

After PR the orphaned comments will be hidden. Removing the parent comment will also remove nested comments.

To test:

  • Navigate to reader comment list with nested comments and enough top level comments to trigger paging.
  • Remove top level comment and confirm that the nested comment is removed as well.
  • Reply to the post when not all the comments are loaded.
  • Reply to comment.
  • Smoke test general comment list behavior.

Regression Notes

  1. Potential unintended areas of impact
  • Unforeseen issue with comment list. Nothing specific that I can think of.
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  2. What automated tests I added (or what prevented me from doing so)
    Legacy code is not very testable.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 23, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 23, 2022

You can test the changes on this Pull Request by downloading the APKs:

@khaykov khaykov marked this pull request as ready for review February 24, 2022 22:41
@khaykov khaykov requested a review from develric February 25, 2022 21:28
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @khaykov 🙇 ! I tested it and it worked as described, smoke testing was ok; also code LGTM 👍 !

@develric develric merged commit 95ac337 into trunk Feb 25, 2022
@develric develric deleted the issue/remove-nested-comments-when-removing-parent branch February 25, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants