MSD - Today's Stats Card - Metrics #15965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…screen accessed. This will be useful to compare how often stats screen is accessed based on today's cards enabled state.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
… tab accessed. This will be useful to compare how often my site tab is accessed based on today's cards enabled state.
ashiagr
added
[Status] Not Ready for Merge
and removed
[Status] Not Ready for Review
labels
zwarm
approved these changes
Feb 16, 2022
WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTracker.kt
Show resolved
Hide resolved
Base automatically changed from
issue/15201-stats-card-accessibility-improvements
to
trunk
February 18, 2022 10:03
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.kt # WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSourceTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15751
References: p1643829887600439-slack-C0290FLA0RM
This PR ensures that metrics are properly added for
Today's Stats Dashboard Card.To Test:
Setup
MySiteDashboardTodaysStatsCardFeatureConfigis to set to onThen follow instructions on how to enable
Stats -> Days#15908Notice the following trackings in logs:
🔵 Tracked: my_site_dashboard_card_shown, Properties: {"type”:”stats”,”subtype":"todays_stats"}🔵 Tracked: my_site_dashboard_card_footer_action_tapped, Properties: {"type":"stats","subtype":"todays_stats"}🔵 Tracked: my_site_dashboard_card_item_tapped, Properties: {"type":"stats","subtype":"todays_stats"}🔵 Tracked: my_site_dashboard_card_shown, Properties: {"type":"error","subtype":"todays_stats"}🔵 Tracked: my_site_menu_item_tapped, Properties: {"type":"stats"}Additionally, for AB Testing (see p1645013610195379-slack-C0290FLA0RM), notice that today's stats enabled state is tracked as part of the following events:
Stats screen accessed
🔵 Tracked: stats_accessed, Properties: {"org.wordpress.android.util.config.MySiteDashboardTodaysStatsCardFeatureConfig":true,"blog_id":<>,"is_jetpack":<>,"site_type":"blog"}My site tab accessed
🔵 Tracked: my_site_tab_accessed, Properties: {"org.wordpress.android.util.config.MySiteDashboardTodaysStatsCardFeatureConfig":true,"blog_id":<>,"is_jetpack":<>,"site_type":"blog"}Note: Today's stats feature config name is based on this logic. Since
remoteConfigis not yet enabled, you'll notice full java class name for the config flag.Review Instructions:
Review by only one reviewer is sufficient.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.