Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes my site icon indeterminate progress #15958

Conversation

ParagDalvi
Copy link
Contributor

Fixes #13155

To test:

  • My Site -> Change site icon.
  • Select an image and tap on confirm.
  • In the Edit Photo screen tap on the top left x icon and check that the default/previous icon is shown.
  • No indeterminate progress bar on icon.

Before:
https://user-images.githubusercontent.com/29736284/154083329-fad29b9e-ff71-404c-8558-d09760c6e181.mp4

After:
https://user-images.githubusercontent.com/29736284/154081646-3968cd13-7d12-4bc4-be5b-fb5bb6adf92d.mp4

Regression Notes

  1. Potential unintended areas of impact
  • Fixed site icon progress, did not find a case where it may misbehave.
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Manual tests
  1. What automated tests I added (or what prevented me from doing so)
  • Changes do not require extra tests nor do they affect existing.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParagDalvi
Copy link
Contributor Author

Hey @antonis, please provide feedback for these changes

@antonis antonis self-requested a review February 24, 2022 08:06
@antonis antonis self-assigned this Feb 28, 2022
@antonis antonis added this to the 19.4 milestone Feb 28, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 28, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis
Copy link
Contributor

antonis commented Feb 28, 2022

Thank you for stepping forward to contribute to WordPress-Android @ParagDalvi 🙇
I tested your fix and everything works as expected. The code change also looks consistent to me 🎉

I have a small request before getting this merged to the project. Please merge the latest changes from trunk and add a release note. Something like the following line would work:

* [*] My Site: Fixes indeterminate progress bar in site icon when cancelling editing [https://github.com/wordpress-mobile/WordPress-Android/pull/15958] 

Thank you again for your contribution 🙏

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 28, 2022

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis changed the base branch from trunk to release/19.3 March 1, 2022 10:52
@antonis antonis changed the base branch from release/19.3 to trunk March 1, 2022 10:52
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ParagDalvi 👍
The code looks good and works as expected 🎉
Thank you for your contribution 🙇

@antonis antonis merged commit 10ccb71 into wordpress-mobile:trunk Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indeterminate progress bar in site icon when cancelling editing.
2 participants