-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes my site icon indeterminate progress #15958
Fixes my site icon indeterminate progress #15958
Conversation
Hey @antonis, please provide feedback for these changes |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Thank you for stepping forward to contribute to I have a small request before getting this merged to the project. Please merge the latest changes from
Thank you again for your contribution 🙏 |
You can test the changes on this Pull Request by downloading the APKs: |
…ttps://github.com/ParagDalvi/WordPress-Android into fix/13155-indeterminate-progress-bar-in-site-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ParagDalvi 👍
The code looks good and works as expected 🎉
Thank you for your contribution 🙇
Fixes #13155
To test:
Before:
https://user-images.githubusercontent.com/29736284/154083329-fad29b9e-ff71-404c-8558-d09760c6e181.mp4
After:
https://user-images.githubusercontent.com/29736284/154081646-3968cd13-7d12-4bc4-be5b-fb5bb6adf92d.mp4
Regression Notes
site icon progress
, did not find a case where it may misbehave.PR submission checklist:
RELEASE-NOTES.txt
if necessary.