Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack app: Enable account creation #15928

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Feb 10, 2022

Closes #15922

This PR enables signup using WordPress.com in the Jetpack app using the ENABLE_SIGNUP constant.

To test:

  1. Install and login to the Jetpack app.
  2. Notice that Log in or signup with WordPress.com is shown on the Login Prologue screen.
  3. Signup using a new email.
  4. Notice that signup succeeds.

Merging Notes:

  • Don't merge the PR yet, I'll take care of the merging.

Regression Notes

  1. Potential unintended areas of impact
    WordPress app flow.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually.

  3. What automated tests I added (or what prevented me from doing so)
    Updated exiting unit tests for Jetpack app Login Prologue screen.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Base automatically changed from issue/15916-enable-all-sites-jetpack-app to feature/15915-enable-jetpack-app-features February 11, 2022 13:54
@ashiagr ashiagr merged commit 9100652 into feature/15915-enable-jetpack-app-features Feb 11, 2022
@ashiagr ashiagr deleted the issue/15922-allow-account-creation-jetpack-app branch February 11, 2022 13:54
@ashiagr
Copy link
Contributor Author

ashiagr commented Feb 14, 2022

Reviewed as part of feature branch PR #15946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant