Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Handles media from share action #15864

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Editor: Handles media from share action #15864

merged 3 commits into from
Jan 31, 2022

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Jan 27, 2022

Fixes #15735

Adds handling for media from share action.

Notes:

To test:

Share image/video

  1. Open Files and select an image by tapping it.
  2. Tap the Share icon in the bottom menu bar.
  3. Select WordPress, then choose a site to share to.
  4. Select "Add to new post".
  5. Verify that the image is successfully added to the post
Image sharing
image.mp4
Video sharing
video.mp4

Share text action

  1. Select some text (e.g. on the browser)
  2. Choose the share action on the context menu and select share
  3. Select the WordPress app from this PR
  4. Select a site
  5. Verify that the editor opens with the correct shared content
Text sharing
text.mp4

Regression Notes

  1. Potential unintended areas of impact
    Share functionality

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Relied on existing tests and manually tested the share text action

  3. What automated tests I added (or what prevented me from doing so)
    The code changes on the EditPostActivity are not easily testable

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 27, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis added this to the 19.2 milestone Jan 27, 2022
@antonis antonis changed the title Handles media from share action Editor: Handles media from share action Jan 27, 2022
@antonis antonis requested a review from ashiagr January 27, 2022 16:01
@antonis antonis marked this pull request as ready for review January 27, 2022 16:02
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 27, 2022

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @antonis! It works as described. 🙌

Regarding the known issue:

sometime when sharing multiple images the images are added twice

Are we tracking it as an issue? If not, I'd suggest creating one before we merge the PR.

@antonis
Copy link
Contributor Author

antonis commented Jan 31, 2022

Thank you for your review @ashiagr 🙇‍♂️

Are we tracking it as an issue? If not, I'd suggest creating one before we merge the PR.

I opened an issue and updated the PR description.

@antonis antonis merged commit 4f68791 into trunk Jan 31, 2022
@antonis antonis deleted the fix/15735-share_image branch January 31, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing image as new post not working. Returns "null" value
2 participants