Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Prevents the editor from hanging on Share text and Reblog actions #15697

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Dec 10, 2021

Fixes #14972 and wordpress-mobile/gutenberg-mobile#4040

Description

Moves shared text and reblog content setup on post creation to prevent editor from hanging

To test:

Share action

  1. Select some text (e.g. on the browser)
  2. Choose the share action on the context menu and select share
  3. Select the WordPress app from this PR
  4. Select a site
  5. Verify that the editor opens with the correct shared content

Reblog action

  1. Launch WPAndroid
  2. Navigate to Reader
  3. Find a post and tap the re-blog button
  4. Select a site and press the check button at the top-right
  5. Verify that the editor opens with the reblogged post content

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Relied on existing tests ReblogUseCaseTest and ReblogUtilsTest

  3. What automated tests I added (or what prevented me from doing so)
    The code changes on the EditPostActivity are not easily testable

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 10, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis marked this pull request as ready for review December 10, 2021 13:49
@antonis antonis self-assigned this Dec 10, 2021
@antonis antonis modified the milestones: 18.9, 19.0 Dec 10, 2021
@antonis antonis requested review from develric and mkevins December 10, 2021 13:58
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 10, 2021

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis modified the milestones: 19.0, 18.9 Dec 10, 2021
@antonis antonis changed the title Editor: Prevents the editor from handing on Reblog action Editor: Prevents the editor from handing on Share text and Reblog actions Dec 10, 2021
@antonis antonis modified the milestones: 18.9, 19.0 Dec 13, 2021
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as described @antonis , thanks for taking care of it 🙇 ! Also code LGTM; feel free to merge once the release note is updated based on target 👍

@antonis antonis modified the milestones: 19.0, 18.9 Dec 13, 2021
@antonis
Copy link
Contributor Author

antonis commented Dec 13, 2021

Thank you for the prompt review @develric 🙇‍♂️

feel free to merge once the release note is updated based on target 👍

I'll update the release notes and merge 👍

@antonis antonis enabled auto-merge December 13, 2021 14:44
@antonis antonis merged commit 982f016 into develop Dec 13, 2021
@antonis antonis deleted the fix/14972-reblogEditor branch December 13, 2021 14:45
@AliSoftware AliSoftware changed the title Editor: Prevents the editor from handing on Share text and Reblog actions Editor: Prevents the editor from hanging on Share text and Reblog actions Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader: re-blogging causes editor to display loading indicator indefinitely
2 participants