-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Prevents the editor from hanging on Share text and Reblog actions #15697
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as described @antonis , thanks for taking care of it 🙇 ! Also code LGTM; feel free to merge once the release note is updated based on target 👍
Thank you for the prompt review @develric 🙇♂️
I'll update the release notes and merge 👍 |
Fixes #14972 and wordpress-mobile/gutenberg-mobile#4040
Description
Moves shared text and reblog content setup on post creation to prevent editor from hanging
To test:
Share action
Reblog action
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Relied on existing tests
ReblogUseCaseTest
andReblogUtilsTest
What automated tests I added (or what prevented me from doing so)
The code changes on the
EditPostActivity
are not easily testablePR submission checklist:
RELEASE-NOTES.txt
if necessary.