Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Bring in the React Native 0.66 upgrade of gutenberg-mobile #15566

Merged
merged 13 commits into from
Jan 3, 2022

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 12, 2021

Update gutenberg-mobile to include the upgrade to React Native 0.66.x

Related PRs

To test:

Performed Gutenberg Mobile Writing Flow, UBE, and Sanity test cases.

Regression Notes

  1. Potential unintended areas of impact
    Regressions in the block editor from upgrading the foundational third-party dependency utilized.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Performed Gutenberg Mobile Writing Flow, UBE, and Sanity test cases.
  3. What automated tests I added (or what prevented me from doing so)
    Not really possible or relevant for this type of dependency upgrade work.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@hypest hypest added this to the Future milestone Nov 12, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2021

You can test the changes on this Pull Request by downloading the APKs:

@hypest
Copy link
Contributor Author

hypest commented Dec 2, 2021

The currently failing jobs due to Incompatible classes were found in dependencies. Remove them from the classpath or use '-Xskip-metadata-version-check' to suppress errors will be fixed when #15642 lands and we update to it.

@dcalhoun dcalhoun marked this pull request as ready for review December 6, 2021 23:17
@dcalhoun dcalhoun requested review from twstokes and dcalhoun December 9, 2021 15:59
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR are expectedly minimal. Much of the WPAndroid Writing Flow, Unsupported Block Editor, and additional features were tested against wordpress-mobile/gutenberg-mobile#4235.

LGTM. Before we merge this PR, we need to update the gutenbergMobileVersion reference to a new tag.

@dcalhoun dcalhoun self-assigned this Jan 3, 2022
@dcalhoun dcalhoun merged commit 2ec6cac into develop Jan 3, 2022
@dcalhoun dcalhoun deleted the gb/upgrade-to-rn-0.66 branch January 3, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants