Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PR list generation at code freeze #15564

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

loremattei
Copy link
Contributor

This PR removes the step in Fastlane's code_freeze lane that generates a text file with a list of the PRs that made it to the new version. With the current process to generate the release notes and the new tooling we built to generate the draft of the release announcement, this file is not used anymore.

This is also removing the get_pullrequests_list lane.

Regression Notes

  1. Potential unintended areas of impact
    --

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    --

  3. What automated tests I added (or what prevented me from doing so)
    --

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@loremattei loremattei added this to the 18.7 milestone Nov 12, 2021
@loremattei loremattei requested a review from a team November 12, 2021 14:04
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@loremattei loremattei enabled auto-merge November 12, 2021 14:04
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@loremattei loremattei merged commit 0f11c4f into develop Nov 12, 2021
@loremattei loremattei deleted the remove/pr-list-at-codefreeze branch November 12, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants