Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reader related posts loading the wrong post after rotation #15352

Merged
merged 9 commits into from
Oct 6, 2021
Merged

Fix reader related posts loading the wrong post after rotation #15352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd41a74
Restore state of ReaderPostDetailFragment on onViewCreated instead of…
dnalves Sep 19, 2021
2a9191f
Add reader related posts rotation fix to RELEASE-NOTES
dnalves Sep 19, 2021
e590c44
Merge branch 'develop' into fix-reader-related-post-rotation
dnalves Sep 20, 2021
66b647e
Update RELEASE-NOTES
dnalves Sep 20, 2021
61b3afb
Merge branch 'develop' into fix-reader-related-post-rotation
dnalves Sep 21, 2021
79d8612
Update RELEASE-NOTES
dnalves Sep 21, 2021
c75d4e8
Merge remote-tracking branch 'upstream/develop' into fix-reader-relat…
dnalves Oct 5, 2021
a2be846
Merge branch 'develop' into fix-reader-related-post-rotation
jd-alexander Oct 6, 2021
ad22e6f
Merge branch 'develop' into fix-reader-related-post-rotation
jd-alexander Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

18.5
-----
* [*] Fixed an issue where navigating through a couple of related posts in Reader caused the incorrect post to be loaded after rotation [https://github.com/wordpress-mobile/WordPress-Android/issues/14195]
* [*] Allow users to mark Posts as sticky [https://github.com/wordpress-mobile/WordPress-Android/pull/15351]
* [*] Fixed a crash in Page Template chooser [https://github.com/wordpress-mobile/WordPress-Android/pull/15415]

Expand Down
8 changes: 2 additions & 6 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,8 @@ class ReaderPostDetailFragment : ViewPagerFragment(),

initLikeFacesRecycler(savedInstanceState)
initViewModel(binding, savedInstanceState)
restoreState(savedInstanceState)
setHasOptionsMenu(true)

showPost()
}
Expand Down Expand Up @@ -841,12 +843,6 @@ class ReaderPostDetailFragment : ViewPagerFragment(),
super.onSaveInstanceState(outState)
}

override fun onActivityCreated(savedInstanceState: Bundle?) {
super.onActivityCreated(savedInstanceState)
setHasOptionsMenu(true)
restoreState(savedInstanceState)
}

private fun restoreState(savedInstanceState: Bundle?) {
savedInstanceState?.let {
blogId = it.getLong(ReaderConstants.ARG_BLOG_ID)
Expand Down