Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.58.0 #15054

Merged
merged 13 commits into from
Jul 23, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jul 22, 2021

Description

This PR incorporates the 1.58.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3746

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 22, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 22, 2021

You can test the changes on this Pull Request by downloading the APKs:

@SiobhyB SiobhyB requested a review from fluiddot July 22, 2021 10:36
@SiobhyB SiobhyB marked this pull request as ready for review July 22, 2021 10:36
@fluiddot fluiddot added this to the 17.9 milestone Jul 22, 2021
Siobhan added 2 commits July 22, 2021 12:42
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Siobhan and others added 4 commits July 22, 2021 12:55
This brings the notes in line with previous releases, which have included a "Block editor" indicator with any changes coming from Mobile Gutenberg.
…ress-mobile/WordPress-Android into gutenberg/integrate_release_1.58.0
@fluiddot
Copy link
Contributor

⚠️ After I open and close a post/page, the next time I open a post/page the editor gets stuck loading. I debugged the build and looks like it's failing with the following error:

TypeError: Cannot read property 'replace' of undefined
    
    This error is located at:
        in R
        in WithDispatch(R)
        in Unknown
        in WithSelect(WithDispatch(R))
        in k
        in S
        in WithDispatch(S)
        in Unknown
        in WithSelect(WithDispatch(S))
        in P
        in RCTView
        in Unknown
        in RCTView
        in Unknown
        in C, js engine: hermes

We should investigate this issue further before proceeding with the release.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 22, 2021

Thank you for spotting that, Carlos. 🙇‍♀️ I'm being pointed to this file when I replicate locally:

Screenshot_1626963083

@antonis, I was just wondering whether this may be related to the recent changes you made in #15050?

@antonis
Copy link
Contributor

antonis commented Jul 22, 2021

@antonis, I was just wondering whether this may be related to the recent changes you made in #15050?

Thank you for the ping @SiobhyB. This indeed seems related since it is enables the Global Styles feature. Looking at it 👀

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Remove reference to feature that's since been reverted.
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

I did a quick test (build 112883) with Samsung Galaxy S20 FE 5G (Android 10) and worked fine. I also confirm that the freezing issue is no longer happening 🥳 .

NOTE: Before merging this PR, we have to change the Gutenberg Mobile ref to point to the release tag v1.58.0.

@SiobhyB SiobhyB merged commit 956b06f into develop Jul 23, 2021
@SiobhyB SiobhyB deleted the gutenberg/integrate_release_1.58.0 branch July 23, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants