-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Enable inserter block search #15044
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
@jhnstn This is looking really close! I'm not seeing the block search UI on the sibling WPiOS PR but I took this Android build for a spin and have a few bits of feedback, one of which I'd consider a blocker.
|
@iamthomasbishop I believe this is the same issue mentioned here. Carlos has worked on this quite a bit and doesn't look like there is a clear fix coming anytime soon. |
f860207
to
1a4c531
Compare
We've resolved this by making the inserter fullscreen by default.
I am unable to reproduce this with the recent fullscreen changes. |
Generated by 🚫 dangerJS |
Gutenberg changes merged. |
Enables inserter block search in the editor
See wordpress-mobile/gutenberg-mobile#3867
To test:
See wordpress-mobile/gutenberg-mobile#3867
Regression Notes
Potential unintended areas of impact
Editor: Block Inserter Menu
What I did to test those areas of impact (or what existing automated tests I relied on)
See Enable Inserter Search gutenberg-mobile#3867
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txt
if necessary.