Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Enable inserter block search #15044

Closed
wants to merge 10 commits into from

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jul 19, 2021

Enables inserter block search in the editor
See wordpress-mobile/gutenberg-mobile#3867

To test:
See wordpress-mobile/gutenberg-mobile#3867

Regression Notes

  1. Potential unintended areas of impact
    Editor: Block Inserter Menu

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    See Enable Inserter Search gutenberg-mobile#3867

  3. What automated tests I added (or what prevented me from doing so)
    None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 19, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jhnstn jhnstn changed the title Editor/enable inserter block search [Editor] Enable inserter block search Jul 19, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 20, 2021

You can test the changes on this Pull Request by downloading the APKs:

@iamthomasbishop
Copy link

@jhnstn This is looking really close! I'm not seeing the block search UI on the sibling WPiOS PR but I took this Android build for a spin and have a few bits of feedback, one of which I'd consider a blocker.

  • [Blocker] I'm seeing some weird transitions when switching between the short and tall sheets (video). It looks like the sheet height is jumping to full before transitioning back down to the desired height, and vice versa, although it is less jarring when going back to the compact sheet. Note: I would consider this a blocker, assuming it's reproducible.
  • The scroll container is cutting off the content on scroll on the tall sheet (example)
  • The search input looks a bit small on Android. For reference, it should be 48px tall, but looks about ~40-42px (comparison)

@jhnstn
Copy link
Member Author

jhnstn commented Jul 21, 2021

[Blocker] I'm seeing some weird transitions when switching between the short and tall sheets (video). It looks like the sheet height is jumping to full before transitioning back down to the desired height, and vice versa, although it is less

@iamthomasbishop I believe this is the same issue mentioned here. Carlos has worked on this quite a bit and doesn't look like there is a clear fix coming anytime soon.

@jhnstn jhnstn force-pushed the editor/enable-inserter-block-search branch from f860207 to 1a4c531 Compare August 24, 2021 20:25
@jhnstn
Copy link
Member Author

jhnstn commented Aug 24, 2021

  • [Blocker] I'm seeing some weird transitions when switching between the short and tall sheets (video). It looks like the sheet height is jumping to full before transitioning back down to the desired height, and vice versa, although it is less jarring when going back to the compact sheet. Note: I would consider this a blocker, assuming it's reproducible.

We've resolved this by making the inserter fullscreen by default.

  • The scroll container is cutting off the content on scroll on the tall sheet (example)

I am unable to reproduce this with the recent fullscreen changes.

@jhnstn jhnstn marked this pull request as ready for review August 24, 2021 21:30
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@jhnstn
Copy link
Member Author

jhnstn commented Aug 25, 2021

Gutenberg changes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants