Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewBinding: Refactor: Remove view binding backing fields #14872

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jun 18, 2021

Parent #14845

This PR removes the binding backing fields from LayoutPreviewFragment and SiteSettingsTimezoneBottomSheet

To test:
LayoutPreviewFragment

-Launch the app
-Navigate to My Site -> FAB -> Site Page
-(1) Note that the category bar along the top works correctly (select/unselect)
-Select a page layout (you will see the check on the page layout)
-Tap the preview button
-(2) Note that the preview shows as expected
-Navigate back to My Site
-Tap the site chooser
-Select + in the upper right hand corner and tap "Create WordPress.com site"
-(3) Note that the category bar along the top works correctly
-Select a page layout (you will see the check on the page layout)
-Tap the preview button
-(4) Note that the preview shows as expected


SiteSettingsTimezoneBottomSheet
-Launch the app
-Navigate to My Site -> Settings -> Timezone
-(1) Note the view is shown and works as expected

Regression Notes

  1. Potential unintended areas of impact
    The Layout selection preview or timezone settings do not work as expected

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual tested both features

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 17.7 milestone Jun 18, 2021
@zwarm zwarm requested a review from ParaskP7 June 18, 2021 20:41
@zwarm zwarm self-assigned this Jun 18, 2021
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7 ParaskP7 self-assigned this Jun 22, 2021
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @zwarm !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟

@ParaskP7 ParaskP7 merged commit d4d4cfa into develop Jun 22, 2021
@ParaskP7 ParaskP7 deleted the issue/14845-remove-backing-fields branch June 22, 2021 08:35
@ParaskP7 ParaskP7 changed the title Refactor: Remove view binding backing fields ViewBinding: Refactor: Remove view binding backing fields Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants