ViewBinding: Refactor: Remove view binding backing fields #14872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #14845
This PR removes the binding backing fields from
LayoutPreviewFragment
andSiteSettingsTimezoneBottomSheet
To test:
LayoutPreviewFragment
-Launch the app
-Navigate to My Site -> FAB -> Site Page
-(1) Note that the category bar along the top works correctly (select/unselect)
-Select a page layout (you will see the check on the page layout)
-Tap the preview button
-(2) Note that the preview shows as expected
-Navigate back to My Site
-Tap the site chooser
-Select + in the upper right hand corner and tap "Create WordPress.com site"
-(3) Note that the category bar along the top works correctly
-Select a page layout (you will see the check on the page layout)
-Tap the preview button
-(4) Note that the preview shows as expected
SiteSettingsTimezoneBottomSheet
-Launch the app
-Navigate to My Site -> Settings -> Timezone
-(1) Note the view is shown and works as expected
Regression Notes
Potential unintended areas of impact
The Layout selection preview or timezone settings do not work as expected
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual tested both features
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.