[Gutenberg] Add enableCaching param to fetch request in edit post activity
#14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
Gutenberg
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Apr 26, 2021
|
You can test the changes on this Pull Request by downloading the APK here. |
jd-alexander
approved these changes
May 11, 2021
fluiddot
commented
May 12, 2021
| @@ -7,7 +7,7 @@ buildscript { | |||
| ext.kotlin_ktx_version = '1.2.0' | |||
| ext.wordPressUtilsVersion = '1.40.0' | |||
| ext.detektVersion = '1.15.0' | |||
| ext.gutenbergMobileVersion = 'v1.52.0' | |||
| ext.gutenbergMobileVersion = 'develop-b34dd4a03c462e285aab5a391ebf84799fbba48b' | |||
There was a problem hiding this comment.
@jd-alexander I'd like to confirm with you that this is the proper way to set the Gutenberg Mobile ref before merging this PR.
There was a problem hiding this comment.
@fluiddot yes it. Once you have verified that the editor binary has been built on S3 you are good to go.
There was a problem hiding this comment.
I confirmed that the editor binary was uploaded, in fact, all checks are 🟢 in the commit.
Ok, thank @jd-alexander for confirming it, I'll merge it 🎊 !
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenbergPR: WordPress/gutenberg#31186gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3419This PR introduces the param
enableCachingin the fetch request method of the edit post activity to allow Gutenberg to control caching of the network requests.To test:
Check testing instructions in the
gutenbergPR.Regression Notes
These changes should only affect Gutenberg-mobile so I don't foresee any potential unintended areas of impact apart from that one.
I verified that the requests made from Gutenberg-mobile were cached or not depending on the
enableCachingparam.Additionally, this code is tested within this unit test.
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.