Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal Layout Picker] Retry view #13159

Merged
merged 45 commits into from
Oct 26, 2020
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
c201d76
Requests scaled thumbnail images
Oct 7, 2020
01b7f8a
Merge branch 'issue/2452-Preview' into issue/2445-ScaledThumb
Oct 8, 2020
3cfbbd9
Shows message after creating a new page
Oct 8, 2020
d32bf8a
Merge branch 'issue/2452-Preview' into issue/2445-ScaledThumb
Oct 9, 2020
d0b0245
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 9, 2020
85289e2
Removed deprecated tests related to title visibility in landscape mode
Oct 9, 2020
7a1c8b3
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 9, 2020
61e1620
Updates tests broken after merge
Oct 9, 2020
1acae0f
Fixes landscape xml issue
Oct 9, 2020
88bffa7
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 9, 2020
99427fe
Adds analytics for template preview and apply
Oct 9, 2020
c24a506
Moved analytics to the editor
Oct 9, 2020
cf4b09b
Removes unused import
Oct 9, 2020
6c85c8f
Prevents VM on rotation
Oct 12, 2020
94f60e7
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 12, 2020
4af9c97
Merge branch 'issue/2453-NewPageToast' into issue/2454-MLP_Analytics
Oct 12, 2020
06d0f26
Allows creation of blank page in offline / loading mode
Oct 12, 2020
1c3f941
Sets page title according to the selected template
Oct 12, 2020
5b75ddd
Merge branch 'issue/2452-Preview' into issue/2445-ScaledThumb
Oct 13, 2020
bc53c64
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 13, 2020
40528bf
Merge branch 'issue/2453-NewPageToast' into issue/2454-MLP_Analytics
Oct 13, 2020
9886321
Merge branch 'issue/2454-MLP_Analytics' into issue/2456-Cache
Oct 13, 2020
f422eb0
Updates FluxC reference
Oct 14, 2020
a8a61ba
Minor optimisation in layout selection handling
Oct 14, 2020
de5ee7f
Removed unused import
Oct 14, 2020
ded2a9a
Adjusted title visibility threshold and added fade animation
Oct 15, 2020
b7c5a92
Merge branch 'develop' into issue/2445-ScaledThumb
Oct 16, 2020
f2e3a23
Merge branch 'issue/2445-ScaledThumb' into issue/2453-NewPageToast
Oct 16, 2020
80ba44f
Prevents new page message from showing when reopening local drafts
Oct 16, 2020
ece4b82
Merge branch 'issue/2453-NewPageToast' into issue/2454-MLP_Analytics
Oct 16, 2020
0812184
Mutes unneeded analytics in editor preview mode
Oct 16, 2020
94d71e9
Updated FluxC reference
Oct 16, 2020
2537de9
Shows the default empty view when no data can be loaded
Oct 16, 2020
8916f73
Merge branch 'develop' into issue/2454-MLP_Analytics
Oct 16, 2020
8aed243
Merge branch 'issue/2454-MLP_Analytics' into issue/2456-Cache
Oct 16, 2020
4d6a3fc
Merge branch 'issue/2456-Cache' into issue/MLP_RetryView
Oct 16, 2020
552c979
Shows toast on error state
Oct 16, 2020
d2b1110
Moves error view below recycler view to tackle scroll issues
Oct 16, 2020
0b9bc48
Merge branch 'issue/2456-Cache' into issue/MLP_RetryView
Oct 16, 2020
2a5e711
Merge branch 'develop' into issue/MLP_RetryView
Oct 16, 2020
a38cb55
Merge branch 'develop' into issue/MLP_RetryView
Oct 19, 2020
5b9ff44
Handles error state on resume
Oct 19, 2020
3239d4a
MLP Error view design improvements
Oct 20, 2020
ea6cf86
Sets create blank page button visible in loading state
Oct 20, 2020
3535abd
Merge branch 'develop' into issue/MLP_RetryView
Oct 26, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed deprecated tests related to title visibility in landscape mode
Antonis Lilis committed Oct 9, 2020
commit 85289e21c23a9fab78d995e6d523c42bfaf192e7
Original file line number Diff line number Diff line change
@@ -116,22 +116,6 @@ class ModalLayoutPickerViewModelTest {
}
}

@ExperimentalCoroutinesApi
@Test
fun `when modal layout picker starts in landscape mode the title is visible`() = mockFetchingSelectedSite {
viewModel.createPageFlowTriggered()
viewModel.start(true)
assertThat(requireNotNull(viewModel.uiState.value as ContentUiState).isHeaderVisible).isEqualTo(true)
}

@ExperimentalCoroutinesApi
@Test
fun `when modal layout picker starts in portrait mode the title is not visible`() = mockFetchingSelectedSite {
viewModel.createPageFlowTriggered()
viewModel.start(false)
assertThat(requireNotNull(viewModel.uiState.value as ContentUiState).isHeaderVisible).isEqualTo(false)
}

@ExperimentalCoroutinesApi
@Test
fun `when the user scroll beyond a threshold the title becomes visible`() = mockFetchingSelectedSite {