Issue/12039 reader table events #12502
Conversation
zwarm
added
[Status] Not Ready for Merge
Part of a WIP Feature
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
| @@ -526,10 +532,15 @@ public static int deletePostsWithTag(final ReaderTag tag) { | |||
| } | |||
|
|
|||
| String[] args = {tag.getTagSlug(), Integer.toString(tag.tagType.toInt())}; | |||
| return ReaderDatabase.getWritableDb().delete( | |||
| int rowsDeleted = ReaderDatabase.getWritableDb().delete( | |||
There was a problem hiding this comment.
This method was directly returning the int value. I changed to keep the value local and will only post the new event if rows have actually been deleted.
| @@ -538,20 +549,30 @@ public static int removeTagsFromPost(long blogId, long postId, final ReaderTagTy | |||
| } | |||
|
|
|||
| String[] args = {Integer.toString(tagType.toInt()), Long.toString(blogId), Long.toString(postId)}; | |||
| return ReaderDatabase.getWritableDb().delete( | |||
| int rowsDeleted = ReaderDatabase.getWritableDb().delete( | |||
There was a problem hiding this comment.
Another instance of the method directly returning the int value. I changed to keep the value local and will only post the new event is rows have actually been deleted.
| } | ||
|
|
||
| public static int deletePostsInBlog(long blogId) { | ||
| String[] args = {Long.toString(blogId)}; | ||
| return ReaderDatabase.getWritableDb().delete("tbl_posts", "blog_id = ?", args); | ||
| int rowsDeleted = ReaderDatabase.getWritableDb().delete("tbl_posts", "blog_id = ?", args); |
There was a problem hiding this comment.
Another instance of the method directly returning the int value. I changed to keep the value local and will only post the new event is rows have actually been deleted.
| ) : CoroutineScope { | ||
| override val coroutineContext: CoroutineContext | ||
| get() = bgDispatcher | ||
|
|
||
| private var isStarted = false | ||
| private val isDirty = AtomicBoolean() |
There was a problem hiding this comment.
AtomicBoolean may be overkill, but considering there may be multiple event posts felt it was safer. Open to thoughts.
|
You can test the changes on this Pull Request by downloading the APK here. |
zwarm
added
New Reader Android
Reader
and removed
Part of a WIP Feature
Addresses part of #12039
This PR introduces EventBus events into
ReaderPostTable.javaandReaderDatabase.javato notify the Reader repositories that the underlyingtbl_postshas been modified (inserts, updates, deletes). If the posts stream has active observers, the repository will refresh itself, otherwise it sets a flag and will await active observers before refreshing.This should not affect any existing workflows.
This PR is branched off of and builds upon #12454. Once #12454 is merged, then I will update this PR with the latest.