Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test strikethrough fix in Aztec #12483

Closed
wants to merge 2 commits into from

Conversation

cameronvoell
Copy link
Contributor

Fixes #wordpress-mobile/gutenberg-mobile#729

To test:

  1. Create a new post
  2. Press strikethrough button
  3. Start typing
  4. add some none strikethrough text afterwards or navigate to a new block
  5. Return to strikethrough text and verify the strikethrough toolbar button is highlighted
  6. highlight the strikethrough text
  7. press the strikethrough button
  8. verify that the text is no longer showing strikethrough

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 21, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@cameronvoell
Copy link
Contributor Author

Branches need to be rebaseed because of gutenberg changes that only landed in gutenberg/after_release_1.33.0. Will update tomorrow.

@cameronvoell cameronvoell force-pushed the test-aztec-update-strikethrough branch from f59b8c0 to 71b1c5c Compare July 21, 2020 19:09
@cameronvoell cameronvoell changed the base branch from develop to gutenberg/after_release_1.33.0 July 21, 2020 19:09
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Base automatically changed from gutenberg/after_release_1.33.0 to develop July 28, 2020 16:09
@cameronvoell cameronvoell deleted the test-aztec-update-strikethrough branch July 31, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant